block / mysql

83%

master: 83%

Pull #1

github

conn: reject named params and fix scan types on the unified path

Two divergences from the normal query path, both found in review.

QueryResultContext accepted driver.NamedValue with Name set and bound
it positionally. QueryContext and ExecContext route args through
namedValueToValue, which rejects named parameters outright; the unified
path skipped that and went straight to CheckNamedValue. Under an
InterpolateParams DSN a caller passing sql.Named would have silently
got a positional bind. Reuse namedValueToValue for the rejection, then
apply CheckNamedValue to the extracted values -- Raw still bypasses
database/sql's conversion, so that part is still needed here.

ColumnTypeScanType reported the parsed Go type (int32, sql.NullTime,
...) while raw rows deliver every non-NULL cell as []byte, so a caller
asserting driver.RowsColumnTypeScanType was told the wrong thing about
what Next yields. Report scanTypeBytes when raw is set. The other
ColumnType methods describe the column rather than the delivered value
and stay as they are.

Both are covered in TestQueryResultContext and fail without the fix.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

56 of 73 new or added lines in 3 files covered. (76.71%)

3443 of 4168 relevant lines covered (82.61%)

2573385.23 hits per line