Coveralls logob

apache / arrow
4%

DEFAULT BRANCH: master
Repo Added 20 Oct 2017 07:20PM UTC
Total Files 48
# Builds 77 Last
Badge
Badge Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

29 Jan 2019 - 16:25 coverage decreased (-76.2%) to 3.722%
14275

push

travis-ci

269a282ad4abf7c71a0be86e6b654ec2?size=18&default=identiconkszucs 
ARROW-4395: [JS] Fix ts-node error running bin/arrow2csv

`ts-node` type-checking is inaccurate, because it only checks files that are touched by node's `require()` calls, leading to errors like this:
```sh
$ cat test/data/cpp/stream/simple.arrow | ./bin/arrow2csv.js

/home/ptaylor/dev/arrow/js/node_modules/ts-node/src/index.ts:228
    return new TSError(diagnosticText, diagnosticCodes)
           ^
TSError: ⨯ Unable to compile TypeScript:
src/vector/map.ts(25,57): error TS2345: Argument of type 'Field<T[string | number | symbol]>[]' is not assignable to parameter of type 'Field<T[keyof T]>[]'.
  Type 'Field<T[string | number | symbol]>' is not assignable to type 'Field<T[keyof T]>'.
    Type 'T[string] | T[number] | T[symbol]' is not assignable to type 'T[keyof T]'.
      Type 'T[symbol]' is not assignable to type 'T[keyof T]'.
        Type 'DataType<Type, any>' is not assignable to type 'T[keyof T]'.
          Type 'symbol' is not assignable to type 'keyof T'.
            Type 'symbol' is not assignable to type 'string | number'.
```

The solution is to update ts-node and run it in transpile-only mode.

Closes https://issues.apache.org/jira/browse/ARROW-4395

Author: ptaylor <paul.e.taylor@me.com>
Author: Paul Taylor <paul.e.taylor@me.com>

Closes #3504 from trxcllnt/js/fix-tsnode-typecheck and squashes the following commits:

066327f0 <Paul Taylor> Merge branch 'master' into js/fix-tsnode-typecheck
89b2a7cc <ptaylor> fix ts-node error running bin/arrow2csv

173 of 4648 relevant lines covered (3.72%)

0.04 hits per line

Relevant lines Covered
4648 RELEVANT LINES 173 COVERED LINES
0.04 HITS PER LINE
Source Files on master

Recent Builds

Builds Branch Coverage Commit Committer Type Time Via
15435 ARROW-4560/array_no_dots
11.62
 &lt;a href=&quot;https://github.com/apache/arrow/commit/170d931f9&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/apache/arrow/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/arrow/commit/&amp;lt;a class=&amp;quot;double-link... 9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow Pull #3635 14 Apr 2021 10:55PM UTC travis-ci
14899 ARROW-1896
69.81
 &lt;a href=&quot;https://github.com/apache/arrow/commit/cdc74a543&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/apache/arrow/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/arrow/commit/&amp;lt;a class=&amp;quot;double-link... 9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow Pull #3642 23 Mar 2021 09:58AM UTC travis-ci
14371 union-builder
98.88
 &lt;a href=&quot;https://github.com/apache/arrow/commit/7406cb04d&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/apache/arrow/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/arrow/commit/&amp;lt;a class=&amp;quot;double-link... 9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow Pull #3423 01 Mar 2021 08:11AM UTC travis-ci
14296 ARROW-4263
30.3
 &lt;a href=&quot;https://github.com/apache/arrow/commit/d8f91f79c&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/apache/arrow/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apache/arrow/commit/&amp;lt;a class=&amp;quot;double-link... 9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow Pull #3399 25 Feb 2021 01:04PM UTC travis-ci
14275 master
3.72
 ARROW-4395: [JS] Fix ts-node error running bin/arrow2csv `ts-node` type-checking is inaccurate, because it only checks files that are touched by node's `require()` calls, leading to errors like this: ```sh $ cat test/data/cpp/stream/simple.arrow ... 269a282ad4abf7c71a0be86e6b654ec2?size=18&default=identiconkszucs push 24 Feb 2021 05:59PM UTC travis-ci
See All Builds (75)
Notice exc

Badge your Repo: arrow

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message. 		Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh