apache / arrow
4%

DEFAULT BRANCH: master
Repo Added
Files 542
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

14275

push

travis-ci

kszucs 
ARROW-4395: [JS] Fix ts-node error running bin/arrow2csv

`ts-node` type-checking is inaccurate, because it only checks files that are touched by node's `require()` calls, leading to errors like this:
```sh
$ cat test/data/cpp/stream/simple.arrow | ./bin/arrow2csv.js

/home/ptaylor/dev/arrow/js/node_modules/ts-node/src/index.ts:228
    return new TSError(diagnosticText, diagnosticCodes)
           ^
TSError: ⨯ Unable to compile TypeScript:
src/vector/map.ts(25,57): error TS2345: Argument of type 'Field<T[string | number | symbol]>[]' is not assignable to parameter of type 'Field<T[keyof T]>[]'.
  Type 'Field<T[string | number | symbol]>' is not assignable to type 'Field<T[keyof T]>'.
    Type 'T[string] | T[number] | T[symbol]' is not assignable to type 'T[keyof T]'.
      Type 'T[symbol]' is not assignable to type 'T[keyof T]'.
        Type 'DataType<Type, any>' is not assignable to type 'T[keyof T]'.
          Type 'symbol' is not assignable to type 'keyof T'.
            Type 'symbol' is not assignable to type 'string | number'.
```

The solution is to update ts-node and run it in transpile-only mode.

Closes https://issues.apache.org/jira/browse/ARROW-4395

Author: ptaylor <paul.e.taylor@me.com>
Author: Paul Taylor <paul.e.taylor@me.com>

Closes #3504 from trxcllnt/js/fix-tsnode-typecheck and squashes the following commits:

066327f0 <Paul Taylor> Merge branch 'master' into js/fix-tsnode-typecheck
89b2a7cc <ptaylor> fix ts-node error running bin/arrow2csv

173 of 4648 relevant lines covered (3.72%)

0.04 hits per line

Relevant lines Covered
4648 RELEVANT LINES 173 COVERED LINES
0.04 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
14275 master ARROW-4395: [JS] Fix ts-node error running bin/arrow2csv `ts-node` type-checking is inaccurate, because it only checks files that are touched by node's `require()` calls, leading to errors like this: ```sh $ cat test/data/cpp/stream/simple.arrow ... push kszucs travis-ci pending completion  
14247 master ARROW-4336: [C++] Change default build type to RELEASE The first goal of this change is two fold, to provide a fast default of users with the least amount of compiler warnings. The second goal of this change is to default the `BUILD_WARNING_LEVEL... push wesm travis-ci pending completion  
12627 master ARROW-3970: [Gandiva][C++] Remove unnecessary boost dependencies. Removed the dynamic dependencies since we do not need them. Author: Praveen <praveen@dremio.com> Closes #3137 from praveenbingo/ARROW-3970 and squashes the following commits: 3f... Pull #1170 wesm travis-ci pending completion  
9902 master ARROW-3171: [Java] Enable checkstyle for line length and indentation This change enables checkstyle line length set at 120 columns and indentation checks. Author: Bryan Cutler <cutlerb@gmail.com> Closes #2512 from BryanCutler/java-checkstyle-li... Pull #87 BryanCutler travis-ci pending completion  
6972 master ARROW-2357: [Python] Add microbenchmark for PandasObjectIsNull() Also add Decimal fodder for other benchmarks. @cpcloud Author: Antoine Pitrou <antoine@python.org> Closes #1798 from pitrou/ARROW-2357-benchmarks-pandas-object-is-null and squashe... push xhochy travis-ci pending completion  
2461 master ARROW-866: [Python] Normalize PyErr exc_value to be more predictable It is possible when using `PyErr_Fetch(&exc_type, &exc_value, &traceback)` for the `exc_value` to be a string, tuple or NULL. Calling `PyErr_Normalize` after this will cause `e... Pull #22 wesm travis-ci pending completion  
7712 master update arrow-glib/meson.build Pull #2012 web-flow travis-ci pending completion  
7711 master update arrow-glib/meson.build Pull #2012 web-flow travis-ci pending completion  
7705 master ARROW-2563: [Rust] Poor caching in Travis-CI Pull #2021 web-flow travis-ci pending completion  
7704 master fix Pull #2021 web-flow travis-ci pending completion  
See All Builds (75)