agama-project / agama / 32030425153

83%

push

github

AutoYaST network: Added startmode and bootproto support (#3805)

## Problem

AutoYaST profiles use the `<startmode>` element to define when a network
connection should be started (e.g., `auto`, `manual`, `hotplug`,
`nfsroot`, etc.). Previously, Agama's AutoYaST compatibility layer
ignored this setting and reported it as unsupported.

Similarly, while the `<bootproto>` element (which specifies the boot
protocol) had basic parsing for some values, it was still marked as
unsupported (`"support": "no"`) in `autoyast-compat.json`. This led to
unnecessary noise/warnings from the profile checker since the values
differed, and the `AUTOIP` boot protocol was completely unhandled.

## Solution

This pull request implements comprehensive translation and full
compatibility support for both `startmode` and `bootproto` elements in
AutoYaST network configuration:

1. **Startmode Conversion:**
- Implemented `read_startmode` in `Agama::AutoYaST::ConnectionsReader`
using `Y2Network::Startmode`.
- Maps automatic startmodes (`auto`, `hotplug`, `ifplugd`, `nfsroot`,
along with aliases like `boot`, `on`, `onboot`) to `"autoconnect": true`
in Agama connections.
- Maps manual or off startmodes (`manual`, `off`) to `"autoconnect":
false` and `"status": "down"`, ensuring they remain down during the
installation.
- Ignores invalid or empty startmodes, leaving the connection's default
behavior intact.

2. **Boot Protocol Enhancement:**
- Added explicit mapping for `AUTOIP` boot protocol, which translates to
`"link-local"` for IPv4 (`method4`) and `"disabled"` for IPv6
(`method6`).

3. **Compatibility Reference and Docs Update:**
- Updated `service/share/autoyast-compat.json` to mark both `bootproto`
and `startmode` as fully supported (`"support": "yes"`), referencing
their corresponding target fields in Agama
(`network.connections[].method4`, `method6`, and `autoconnect`).
- Cleaned up `autoyast-examples/README.md` to remove outdated references
to `bootproto` and `startmode` bei... (continued)

4917 of 6864 branches covered (71.63%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 2 files covered. (100.0%)

26617 of 30907 relevant lines covered (86.12%)

120.47 hits per line