Coveralls logob
Coveralls logo
  • Home
  • Features
  • Pricing
  • Docs
  • Sign In

activeadmin / activeadmin / 5398

DEFAULT BRANCH: master
Build:
LAST BUILD BRANCH: backport_phantomjs_removal
Repo Added 24 Aug 2014 03:14PM UTC
Total Files 11
# Builds 1682 Last
Badge
Badge Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

31 Jan 2017 - 19:56 First build on avoid-double-reload-when-routes-change at 89.193%
5398

Pull #4558

travis-ci

9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow
Don't reload routes twice on admin code changes.

If someone makes a change in an `app/admin` file, Rails will trigger a
routes reload by eval'ing `routes.rb` which in turn will call `routes`
on the Active Admin application.

Later, because we've inserted ourselves into the reloading through the
`to_prepare` and `to_complete` callbacks, `to_prepare` will unload our
namespaces while `to_complete` will retrigger a routes and application
reload.

Thus we can reliably skip the first routes reload whenver the reloader
is `updated?`. Because `execute_if_updated` is called if it is updated
the routes will be reloaded at that time. When `execute_if_updated` is
reloading the routes the reloader is no longer `updated?`. Finally, if
the code change wasn't in `app/admin` our reloader won't be `updated?`
there either.
Pull Request #4558: Don't reload routes twice on admin code changes.

1271 of 1425 relevant lines covered (89.19%)

1626.62 hits per line

Jobs
Coverage Job Files Covered Ran
89.19
5398.19 (2.4.0, gemfiles/rails_50.gemfile) 11 02 May 2019 05:36AM UTC Travis Job 5398.19
Source Files on build 5398
  • Tree
  • List 11
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Travis Build #5398
  • Pull Request #4558
Troubleshooting · Open an Issue · Sales · Support · ENTERPRISE · CAREERS · STATUS
BLOG · TWITTER · Legal & Privacy · Supported CI Services · What's a CI service? · Automated Testing

© 2022 Coveralls, Inc