5398

DEFAULT BRANCH: master

LAST BUILD BRANCH: backport_phantomjs_removal

Repo Added 24 Aug 2014 03:14PM UTC

Total Files 11

# Builds 1682 Last

Badge

Embed ▾

Committed 31 Jan 2017 - 19:56 First build on avoid-double-reload-when-routes-change at 89.193%

Build # 5398

Build Type

Pull #4558

travis-ci

Committed by

web-flow

Commit Message

Don't reload routes twice on admin code changes.

If someone makes a change in an `app/admin` file, Rails will trigger a
routes reload by eval'ing `routes.rb` which in turn will call `routes`
on the Active Admin application.

Later, because we've inserted ourselves into the reloading through the
`to_prepare` and `to_complete` callbacks, `to_prepare` will unload our
namespaces while `to_complete` will retrigger a routes and application
reload.

Thus we can reliably skip the first routes reload whenver the reloader
is `updated?`. Because `execute_if_updated` is called if it is updated
the routes will be reloaded at that time. When `execute_if_updated` is
reloading the routes the reloader is no longer `updated?`. Finally, if
the code change wasn't in `app/admin` our reloader won't be `updated?`
there either.

Pull Request Pull Request #4558: Don't reload routes twice on admin code changes.

Run Details

1271 of 1425 relevant lines covered (89.19%)

1626.62 hits per line

Jobs

Coverage	Job	Files Covered	Ran
89.19	5398.19 (2.4.0, gemfiles/rails_50.gemfile)	11	02 May 2019 05:36AM UTC	Travis Job 5398.19

activeadmin / activeadmin / 5398

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5398

activeadmin / activeadmin / 5398

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5398

README BADGES
x