Valian / live_vue

78%

main: 82%

LAST BUILD ON BRANCH bugfix/embed-errors-ordering

branch: bugfix/embed-errors-ordering

CHANGE BRANCH

x

Reset

Sync Branches

• bugfix/embed-errors-ordering
• bugfix/checkboxes
• ci-housekeeping
• create-script
• diff-optimization
• docs-rewrite
• docs/release-notes-1.0
• drop-js-build-step
• e2e
• ecto-dependency-bug
• feat/add-link-component
• feat/frontend-testing
• feat/live-component-refactor
• feature/async-result-encoder
• feature/automatic-usage-rules
• feature/streams
• feature/useEventReply
• feature/useLiveConnection
• feature/vs-code-extension
• file-upload
• fix-comment-on-to-uft8-base-64
• fix-nodejs-server-path
• fix-non-ascii-characters-in-slots
• fix-translate-error-tuples
• fix-ts-errors
• fix-vue-component-import
• fix/exclude-test-files-from-hex
• fix/nillify-vs-nilify
• fix/streams-with-disabled-diff
• fix/update-vulnerabilities
• github-ci-fix
• github-workflow
• igniter-installer
• igniter-root-dir
• improve-test-coverage
• improvement/component-matching
• improvement/lazy-html
• main
• push-qvvtqqmotomq
• remove-example-project
• remove-shared-props
• replace-expublish
• review-docs-for-1.0
• review-e2e-test-structure
• switch-to-typescript
• unnest-js-assets
• use-live-event
• useLiveForm
• useLiveNavigation

Build # eb351221d2d1ea40a36eddb1205e3f6ef71e5654-PR-94

Build Type

Pull #94

github

Committed by Valian

Commit Message

bugfix: correctly filter deleted items from embed_many error arrays

When items are removed from embed_many collections, the error array was
including extra nil values for deleted items, causing misalignment with
the values array.

Root cause: collect_changeset_errors mapped over ALL changesets including
those with params==nil (deleted items), while collect_changeset_values
filtered them out.

Fix: Added Enum.filter(&(&1.params != nil)) to error collection to match
the filtering logic used for values (line 210).

Also added tests verifying error/values array length matching for both
simple and deeply nested embed_many scenarios.

Pull Request Pull Request #94: Fix embed_many error array misalignment when items are removed

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

339 of 435 relevant lines covered (77.93%)

31.87 hits per line