UKGovernmentBEIS / beis-report-official-development-assistance
98%
develop: 99%

LAST BUILD BRANCH: dependabot/bundler/selenium-webdriver-4.36.0
DEFAULT BRANCH: develop
Repo Added
Files 257
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH migration/fix-dsit-beis-forecasts
branch: migration/fix-dsit-beis-forecasts
CHANGE BRANCH
x

coverage: 98.057%. Remained the same
12198712671

Pull #2450

github

mec 
Fix planned disbursement providing organisation

The name of the providing organisation does not match the reference
number in a lot of cases, which we assume happened when BEIS became
DSIT.

This migration fixes that.

Let me explain why this looks 'unusual':

The Forecast model is protected against direct access, for background
see our docs:

https://github.com/UKGovernmentBEIS/beis-report-official-development-assistance/blob/develop/doc/forecasts-and-versioning.md

In this instance the data is simply incorrect, the reference 'GB-GOV-26'
should be named 'DEPARTMENT FOR SCIENCE, INNOVATION AND TECHNOLOGY' and
nothing else. We are not creating new or deleting old Forecast and so
should not upset the versioning.

As we are correcting data we have to touch a lot of Forecasts and the
protection makes this interesting!

For the actual data migration, things are pretty straight forward, we
can use `update_column` to set the name and nothing else.

Testing is where things get more difficult. Due to the protections,
creating a set of Forecasts for testing is extremely convoluted (by
design) we need to put Forecasts into a specific incorrect state.

Instead we've opted to test closer to the database. We've provided a
method to create Forecast in the right state, they would be considered
invalid as models, but that is not under test here, we simply want to
verify that:

- only records in the appropriate state are processed
- only the column we want to change is altered

As it is harder to get the data into the right state to test, we've
included some assertions for the initial state to try and show what is
happening.

I think it is worth remembering that this is a one off fix and is not
really 'production' code that will run day in, day out!
Pull Request #2450: Fix planned disbursement providing organisation

6965 of 7103 relevant lines covered (98.06%)

964.49 hits per line

Relevant lines Covered
7103 RELEVANT LINES 6965 COVERED LINES
964.49 HITS PER LINE
Source Files on migration/fix-dsit-beis-forecasts

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
12198712671 migration/fix-dsit-beis-forecasts Fix planned disbursement providing organisation The name of the providing organisation does not match the reference number in a lot of cases, which we assume happened when BEIS became DSIT. This migration fixes that. Let me explain why this loo... Pull #2450 mec github
98.06
12156200271 migration/fix-dsit-beis-forecasts Fix planned disbursement providing organisation The name of the providing organisation does not match the reference number in a lot of cases, which we assume happened when BEIS became DSIT. This migration fixes that. Let me explain why this loo... Pull #2450 mec github
98.05
12156191237 migration/fix-dsit-beis-forecasts Fix planned disbursement providing organisation The name of the providing organisation does not match the reference number in a lot of cases, which we assume happened when BEIS became DSIT. This migration fixes that. Let me explain why this loo... push mec github
98.05
See All Builds (4354)