UKGovernmentBEIS / beis-report-official-development-assistance
98%
develop: 99%

LAST BUILD BRANCH: dependabot/bundler/selenium-webdriver-4.36.0
DEFAULT BRANCH: develop
Repo Added
Files 257
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 3099-upgrade-devise-two-factor-to-5x
branch: 3099-upgrade-devise-two-factor-to-5x
CHANGE BRANCH
x

coverage: 98.066%. Remained the same
13111640976

Pull #2501

github

rgarner 
5.x devise-two-factor upgrade phase 1

All non-Rails 7 steps already completed from

https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-1-upgrading-devise-two-factor-as-part-of-rails-7-upgrade

Prior to release of this, we need to generate
`ACTIVE_RECORD_ENCRYPTION_PRIMARY_KEY`,
`ACTIVE_RECORD_ENCRYPTION_DETERMINISTIC_KEY`, and
`ACTIVE_RECORD_ENCRYPTION_KEY_DERIVATION_SALT` for each environment,
and make sure they are preloaded in AWS. These are required by Rails 7
for https://guides.rubyonrails.org/active_record_encryption.html which
`devise_two_factor` 5.x uses to encrypt `otp_secret`s (4.x used the
`attr_encrypted` gem).

`bin/rails db:encryption:init` will generate all three; they are
assigned on startup in `application.rb`.

Run:

`rails runner db/data/20250117151047_regenerate_otp_secrets.rb` on
each environment in turn.

`legacy_otp_secret` will cover the period that "new" otp_secrets are
NULL.

We can remove the old DB columns and `legacy_otp_secret` in a separate
release:

https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-2-clean-up

In our case we won't need to copy otp_secret; because we're SMS-only
we're able to do that in the Phase 1 release data migration.

NOTES:

- given that this is the first commit to `schema.rb` since the
  upgrade, some bits like `precision` go away with the Rails 7.0 upgrade
Pull Request #2501: 5.x devise-two-factor upgrade phase 1

7100 of 7240 relevant lines covered (98.07%)

957.23 hits per line

Relevant lines Covered
7240 RELEVANT LINES 7100 COVERED LINES
957.23 HITS PER LINE
Source Files on 3099-upgrade-devise-two-factor-to-5x

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13111640976 3099-upgrade-devise-two-factor-to-5x 5.x devise-two-factor upgrade phase 1 All non-Rails 7 steps already completed from https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-1-upgrading-devise-two-factor-as-part-of-rails-7-upgrade Prior to release of ... Pull #2501 rgarner github
98.07
12946337664 3099-upgrade-devise-two-factor-to-5x 5.x devise-two-factor upgrade phase 1 All non-Rails 7 steps already completed from https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-1-upgrading-devise-two-factor-as-part-of-rails-7-upgrade ## Pre-release: Pri... Pull #2501 rgarner github
98.05
12871450615 3099-upgrade-devise-two-factor-to-5x 5.x devise-two-factor upgrade phase 1 All non-Rails 7 steps already completed from https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-1-upgrading-devise-two-factor-as-part-of-rails-7-upgrade ## Pre-release: Pri... Pull #2501 rgarner github
98.07
12871191176 3099-upgrade-devise-two-factor-to-5x 5.x devise-two-factor upgrade phase 1 All non-Rails 7 steps already completed from https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-1-upgrading-devise-two-factor-as-part-of-rails-7-upgrade ## Pre-release: Pri... Pull #2501 rgarner github
98.07
12832859991 3099-upgrade-devise-two-factor-to-5x 5.x devise-two-factor upgrade phase 1 All non-Rails 7 steps already completed from https://github.com/devise-two-factor/devise-two-factor/blob/main/UPGRADING.md#phase-1-upgrading-devise-two-factor-as-part-of-rails-7-upgrade Although given that ... Pull #2501 rgarner github
98.07
See All Builds (4354)