UKGovernmentBEIS / beis-report-official-development-assistance
99%
develop: 99%

Repo Added 15 Mar 2021 09:18AM UTC

Committed 04 Jan 2024 10:10AM UTC coverage: 98.817% (+0.001%) from 98.816%

Committed by

Commit Message

Model financial values in csv for importing

To try and simplify our approach to importing from csv files this
Import::Csv::Financial class is a basic wrapper for a financial value
that is to be imported from csv.

Our philosophy when importing from csv is that a financial value is to expect:

- a positive number
- a negatvie number
- zero
- any kind of blank space
- invalid
- some kind of financial formatting e.g. 10,000.00

Here, invalid means

> We could not convert the supplied string to a BigDecimal.

This implementation treats a `0` and an empty cell the same,
which makes the upstream import code more approachable as we can
assume everything will be `0`.

We resue the existing `ConvertFinancialValue` service object to do the
actual conversion, dealing with an errors as described above - we chose
this approach over changing the `ConvertFinancialValue` to keep the
changes isolated to the current work.

When we use this class during import, we can expect a financial value to
be one of three states:

- a BigDecimal value
- a zero
- nil

Where nil means it could not be converted.

We also retain the original string value from the csv so it can be
presented back to the user in any error messages.

6685 of 6765 relevant lines covered (98.82%)

985.75 hits per line

6765 RELEVANT LINES 6685 COVERED LINES

985.75 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
7408158066	feature/2931-model-csv-financial-values	Model financial values in csv for importing To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importing fr...	Pull #2284	04 Jan 2024 10:20AM UTC	mec	github	98.82
7385783658	feature/2931-model-csv-financial-values	Model financial values in csv for importing To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importing fr...	Pull #2284	02 Jan 2024 12:40PM UTC	mec	github	98.82
7385176078	feature/2931-model-csv-financial-values	Model financial values in csv for importing To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importing fr...	Pull #2284	02 Jan 2024 11:28AM UTC	mec	github	98.82
7385053037	feature/2931-model-csv-financial-values	Model financial values in csv for importing To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importing fr...	Pull #2284	02 Jan 2024 11:14AM UTC	mec	github	98.82
7384767819	feature/2931-model-csv-financial-values	Model financial values in csv for importing To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importing fr...	Pull #2284	02 Jan 2024 10:42AM UTC	mec	github	98.82
7276261027	feature/2931-model-csv-financial-values	Model financial values in csv for importing To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importing fr...	Pull #2284	20 Dec 2023 01:56PM UTC	mec	github	98.82
7276195794	feature/2931-model-csv-financial-values	Create a class to manage financial values in csv To try and simplify our approach to importing from csv files this Import::Csv::Financial class is a basic wrapper for a financial value that is to be imported from csv. Our philosophy when importi...	push	20 Dec 2023 01:49PM UTC	mec	github	98.82

UKGovernmentBEIS / beis-report-official-development-assistance
99%
develop: 99%

UKGovernmentBEIS / beis-report-official-development-assistance 99% develop: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on feature/2931-model-csv-financial-values

Recent builds

UKGovernmentBEIS / beis-report-official-development-assistance
99%
develop: 99%

README BADGES
x

CHANGE BRANCH
x