Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15036-7f641edc873829ad1ffd795765f769b215d4d5db
DEFAULT BRANCH: main
Repo Added
Files 871
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-14921-536d1db67e420399cd97567db68045350c7cd525
branch: gh-readonly-queue/main/pr-14921-536d1db67e420399cd97567db68045350c7cd525
CHANGE BRANCH
x

coverage: 88.286% (-0.008%) from 88.294%
17085112291

push

github

web-flow 
Cleanup Rust interface for Target::get_non_global_operation_names() (#14921)

* Cleanup Rust interface for Target::get_non_global_operation_names()

This commit cleans up the rust interface for the
Target::get_non_global_operation_names() method. The function was
requiring a mutable reference to the target for querying the data from
rust which is a mismatch from expectations. This was because the
function was trying to cache the result which was a Python-ism that was
faithfully ported when the Target moved from Python to Rust, but this
doesn't really fit in a rust interface because a rust user takes more
care around mutability. The caching is a construct for Python and
doesn't really fit with a rust interface. This commit updates the rust
interface to not cache this data and move it to Python. It's arguable
whether a cache is actually needed for this or not, but just out of an
abundance of caution this leaves it in place. However, the cache is
moved out of the Rust struct to avoid carrying the deadweight around in
a standalone C/Rust context.

* Fix Target python object construction

This commit fixes the object creation path of the Target so there isn't
a path for the target to be created without it's Python space caches
getting created.

* Fix subclassing

* Simplify rust interface

29 of 29 new or added lines in 2 files covered. (100.0%)

14 existing lines in 5 files now uncovered.

88350 of 100072 relevant lines covered (88.29%)

503963.29 hits per line

Relevant lines Covered
100072 RELEVANT LINES 88350 COVERED LINES
503963.29 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-14921-536d1db67e420399cd97567db68045350c7cd525

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
17085112291 gh-readonly-queue/main/pr-14921-536d1db67e420399cd97567db68045350c7cd525 Cleanup Rust interface for Target::get_non_global_operation_names() (#14921) * Cleanup Rust interface for Target::get_non_global_operation_names() This commit cleans up the rust interface for the Target::get_non_global_operation_names() method. ... push web-flow github
88.29
See All Builds (14018)