Qiskit / qiskit
88%

DEFAULT BRANCH: main
Repo Added
Files 932
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 87.526% (+0.03%) from 87.495%
24097438704

push

github

web-flow 
Rewrite QPY `ParameterExpression` handling in pure Polish form (#15934)

* Rewrite QPY `ParameterExpression` handling in pure Polish form

This patch is a fairly invasive change, but one that fixes the known
edge cases of replay generation from `ParameterExpression` itself.  This
fixes several `pickle`, `copy`/`deepcopy` and QPY bugs around
`ParameterExpression`.

The Python-space QPY loader is modified in a small way to allow it to
handle QPY-format permitted "replay" elements that act between two bare
values; this was always allowed by the QPY spec, but couldn't be
generated by Python-space QPY/`ParameterExpression`.  Doing so actually
significantly simplifies the loading logic, since it no longer needs to
reflect certain arithmetic operations.  The new Rust-space
`ParameterExpression` uses binary operations with two numeric operands
(e.g. `Add(2, 0)`) to safely propagate bare values through the QPY
replay.  This was not previously necessary in Python space because there
was no public interface to create a bare-numeric `ParameterExpression`
without replayable expressions having been tracked.  Similarly,
cancelled-out symbols are propagated in the replay with `Sub(x, x)`
operations, which already must work across all compliant QPY loaders,
and both Rust- and Python-space `ParameterExpression.

History
-------

The QPY replay was _intended_ to be a pure Polish-notation
representation of the operations to take to rebuild the expression.
This mostly worked fine at the time, but the patch was written under a
lot of stress and without full CI tooling, due to it being in response
to a security bug.  This led to some less-than-ideal parts of the format
specification, such as the start/end recursion opcodes in the QPY format
not actually being necessary; they are actually zero-operand no-ops to
the stack, but this wasn't noticed during the patch due to time
pressure.

Further, as `ParameterExpression` moved to Rust, the tracked internal
"replay" list disappe... (continued)

167 of 262 new or added lines in 4 files covered. (63.74%)

37 existing lines in 6 files now uncovered.

104435 of 119319 relevant lines covered (87.53%)

1021805.78 hits per line

Relevant lines Covered
119319 RELEVANT LINES 104435 COVERED LINES
1021805.78 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24097438704 main Rewrite QPY `ParameterExpression` handling in pure Polish form (#15934) * Rewrite QPY `ParameterExpression` handling in pure Polish form This patch is a fairly invasive change, but one that fixes the known edge cases of replay generation from `P... push web-flow github
87.53
24045385841 main Fix clippy warning in qpy module (#15951) This commit fixes a clippy error in the qpy module when running clippy with the latest stable rust release. In #15698 we denied the use of unwrap() or expect() to minimize the chance of the qpy module pan... push web-flow github
87.48
24035184870 main Bump uuid from 1.22.0 to 1.23.0 (#15888) * Bump uuid from 1.22.0 to 1.23.0 Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.22.0 to 1.23.0. - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](https://github.com/uuid-rs/uu... push web-flow github
87.48
24034802441 main Bump pyo3 from 0.28.2 to 0.28.3 (#15939) * Bump pyo3 from 0.28.2 to 0.28.3 Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.28.2 to 0.28.3. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob... push web-flow github
87.5
23928373827 main Use quantum_volume() function in the PGO script (#15931) * Use quantum_volume() function in the PGO script This commit updates the pgo utility scale script to use the quantum_volume generator function instead of the legacy QuantumVolume class. W... push web-flow github
87.5
23916456429 main Support commutation check between Pauli-based gates and standard gates (After reverting #15488) (#15925) * Transpiler: implement exact Pauli generators for LightCone in Rust This PR adds exact Pauli generator expansions for the following gates: ... push web-flow github
87.49
23893436460 main Correctly enforce matrix size check in `CommutationChecker` (#15933) * Fixed the matrix size check for non-cachable gates in the commutation checker. A typo in the matrix size check allowed to sneak into a matrix-based check even if the operatio... push web-flow github
87.48
23861125316 main Invert `qiskit-quantum-info` and `qiskit-circuit` dependency (#15915) This moves the last remaining dependency from `qiskit-quantum-info` out of that package and into `qiskit-circuit` itself; rather than `VersorU2` consuming the `StandardGate` to... push web-flow github
88.15
23843194848 main Add type-safe `VecMap` for slices indexed by newtypes (#14910) * Simply Sabre release-valve calculation (#15897) There is an edge case in release-valve handling where, if the shortest path is a single swap (but the heuristics have been chosen su... push web-flow github
87.46
23842181211 main Move Python utilities from `circuit` to `util` (#15910) The base definitions of these objects are unrelated to `qiskit-circuit` and the core circuit IR concepts, and can easily be moved into the `qiskit-util` crate to break further spurious depen... push web-flow github
87.49
See All Builds (16694)