Qiskit / qiskit / 17085112291

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Cleanup Rust interface for Target::get_non_global_operation_names() (#14921)

* Cleanup Rust interface for Target::get_non_global_operation_names()

This commit cleans up the rust interface for the
Target::get_non_global_operation_names() method. The function was
requiring a mutable reference to the target for querying the data from
rust which is a mismatch from expectations. This was because the
function was trying to cache the result which was a Python-ism that was
faithfully ported when the Target moved from Python to Rust, but this
doesn't really fit in a rust interface because a rust user takes more
care around mutability. The caching is a construct for Python and
doesn't really fit with a rust interface. This commit updates the rust
interface to not cache this data and move it to Python. It's arguable
whether a cache is actually needed for this or not, but just out of an
abundance of caution this leaves it in place. However, the cache is
moved out of the Rust struct to avoid carrying the deadweight around in
a standalone C/Rust context.

* Fix Target python object construction

This commit fixes the object creation path of the Target so there isn't
a path for the target to be created without it's Python space caches
getting created.

* Fix subclassing

* Simplify rust interface

Run Details

29 of 29 new or added lines in 2 files covered. (100.0%)

14 existing lines in 5 files now uncovered.

88350 of 100072 relevant lines covered (88.29%)

503963.29 hits per line