Qiskit / coheriq
93%

DEFAULT BRANCH: main
Repo Added
Token jKKuxHj3knTVtM5QGrtJHIfFoNeKYIoVO regen
Build 138 Last
Files 5
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 92.739% (+0.9%) from 91.809%
41546885011

push

github

web-flow 
Report the right type, and stay in the CoheriqError hierarchy (#52)

Two pre-existing problems in how `acceleration_candidate` and `override`
resolve a lookup name.

A non-string `name` reported the type of the decorated function rather
than of `name` itself, so `name=123` complained `got function instead`.
The branch is only reachable when `name` is given, since a name derived
from `__name__` is always a string, so `type(f)` was never the right
thing to report there.

Reading `f.__name__` unguarded raised a bare `AttributeError` naming a
dunder.  That escaped the CoheriqError hierarchy, so a caller wrapping
setup in `except CoheriqError` did not catch it.  It affected two
different situations: a caller error such as passing an int, and
legitimate callables that carry no `__name__`, which includes
`functools.partial` objects and instances of classes defining
`__call__`.  Both now raise CoheriqDomainError or CoheriqEngineError and
point at the explicit `name` argument, which has always worked for them.

The new exception is raised `from None`.  The AttributeError only
restates the attribute the message already names, and "During handling
of the above exception" would suggest coheriq hit a bug when the except
branch is in fact the designed path.

The decorator-side validation had no test, which is how the wrong type
survived; `test_nonstring_name` covers the constructor's name instead.

Assisted-by: Claude Opus 5

12 of 12 new or added lines in 2 files covered. (100.0%)

281 of 303 relevant lines covered (92.74%)

0.93 hits per line

Relevant lines Covered
303 RELEVANT LINES 281 COVERED LINES
0.93 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
41546885011 main Report the right type, and stay in the CoheriqError hierarchy (#52) Two pre-existing problems in how `acceleration_candidate` and `override` resolve a lookup name. A non-string `name` reported the type of the decorated function rather than of `n... push web-flow github
92.74
41545944104 gh-readonly-queue/main/pr-52-97a9f9f411b6aec7d08423c39d92b179d3d568b5 Report the right type, and stay in the CoheriqError hierarchy (#52) Two pre-existing problems in how `acceleration_candidate` and `override` resolve a lookup name. A non-string `name` reported the type of the decorated function rather than of `n... push web-flow github
92.74
41515576801 decorator-name-errors Merge 99abe480d into 97a9f9f41 Pull #52 web-flow github
92.74
41501053300 py-typed Merge b126ee539 into 97a9f9f41 Pull #47 web-flow github
92.26
41498421760 main Resolve each decoration's lookup name independently (#49) `acceleration_candidate` and `override` both did `nonlocal name` and wrote the decorated function's `__name__` into the enclosing scope. When the factory they return is applied more than ... push web-flow github
91.81
41497057046 gh-readonly-queue/main/pr-49-28d877d82218d05b15e5725387e843d56ccb43f6 Resolve each decoration's lookup name independently (#49) `acceleration_candidate` and `override` both did `nonlocal name` and wrote the decorated function's `__name__` into the enclosing scope. When the factory they return is applied more than ... push web-flow github
91.81
41486684171 main Improve the README, user guide, and platform test coverage (#50) * Improve the README, user guide, and platform test coverage The note at the top of the user guide told the reader to call enable_engine before explaining what a domain is or how t... push web-flow github
91.53
41485539770 gh-readonly-queue/main/pr-50-2bdcc29c93522a46129c545584b0d7e1fbdd300f Improve the README, user guide, and platform test coverage (#50) * Improve the README, user guide, and platform test coverage The note at the top of the user guide told the reader to call enable_engine before explaining what a domain is or how t... push web-flow github
91.53
41484248794 readme-improvements Merge 23475fadc into 2bdcc29c9 Pull #50 web-flow github
91.53
41463387891 readme-improvements Merge 7e3310f99 into 2bdcc29c9 Pull #50 web-flow github
91.53
See All Builds (138)

Badge your Repo: coheriq

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh