Qiskit / coheriq / 41497057046

92%

main: 93%

Build Type

push

github

Committed by web-flow

Commit Message

Resolve each decoration's lookup name independently (#49)

`acceleration_candidate` and `override` both did `nonlocal name` and wrote the
decorated function's `__name__` into the enclosing scope.  When the factory
they return is applied more than once and no explicit name was given, every
decoration after the first reused the first function's name:

    decorate = domain.acceleration_candidate()
    w1 = decorate(alpha)
    w2 = decorate(beta)
    # registered: {'alpha': beta};  w1() and w2() both call beta

On the engine side the symptom is worse, because a missing override is not an
error.  The first candidate dispatched to the second candidate's override, and
the second fell through to the reference implementation as though it had never
been overridden.  Both failures are silent.

Resolve into a local instead, so each decoration is independent, and read that
local everywhere the name is used -- the registration, the domain lookup, and
the engine's "not defined in domain" check.

Reusing a factory that *was* given an explicit name is unaffected: both
decorations register under that name, last write winning, exactly as two
separately-created factories with the same name already did.  Applying the
decorator directly was never affected either, which is why this went
unnoticed.

Assisted-by: Claude Opus 5

Coverage Stats

8 of 8 new or added lines in 2 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

269 of 293 relevant lines covered (91.81%)

0.92 hits per line