OpenTreeMap / otm-core
84%
develop: 84%

LAST BUILD BRANCH: dependabot/npm_and_yarn/sockjs-0.3.21
DEFAULT BRANCH: develop
Repo Added
Files 235
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH rtb/hstore
branch: rtb/hstore
CHANGE BRANCH
x

2991

push

travis-ci

RobinIsTheBird 
upgrade HStore

Overview
--------

The point of this commit is to switch from
`django_hstore.fields.DictionaryField` to
`django.contrib.postgres.fields.HStoreField`.

The former is incompatible with later releases of django,
and OpenTreeMap needs to migrate from the current 1.8 to 1.11
for stability.

The latter is the sanctioned django interface to PostgreSQL's hstore
going forward.

The latter is also less functional than the former, prompting a series
of other changes.
Changes were also made for the sake of maintenance simplicity.

The key changes here are in `treemap.udf`, `treemap.audit`, `*.models`, and
`treemap.search`.

**treemap.udf**

Entry points:
-   `UDFModel`, a base class for models that need user defined fields
-   `UserDefinedFieldDefinition`, defines the name, data type, and model type
    for a user defined field, for a given treemap instance, as a
    scalar or a collection
-   `UserDefinedCollectionValue`, an HStore collection value for a
    specific `UserDefinedFieldDefinition` on a specific model instance

`UDFModel` user guide:

Classes that want custom fields subclass `UDFModel`.

To assign a custom field,
    `my_model_instance.udfs['custom field name'] = value`

There are three ways to retrieve it:
    `my_model_instance.udfs['custom field name']`
    `getattr(my_model_instance, 'custom field name')`
    `getattr(my_model_instance, 'udf:custom field name'`)

All of the above work for both scalar and collection custom fields.

Filter `UDFModel` subclass querysets using the `udf` transform.

In addition to the transforms and lookups described at
https://docs.djangoproject.com/en/1.8/ref/contrib/postgres/fields/,
`UDFModel` implements `__int` and `__float` transforms, for use
before magnitude comparisons (`__gt`, `__gte`, `__lt`, `__lte`).
Without them, comparison is lexical, which does not yield the
same results as a numerical comparison.

For example, to filter a queryset for a custom field value
corresponding to an integer ... (continued)

17435 of 20867 relevant lines covered (83.55%)

0.84 hits per line

Relevant lines Covered
20867 RELEVANT LINES 17435 COVERED LINES
0.84 HITS PER LINE
Source Files on rtb/hstore
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2991 rtb/hstore upgrade HStore Overview -------- The point of this commit is to switch from `django_hstore.fields.DictionaryField` to `django.contrib.postgres.fields.HStoreField`. The former is incompatible with later releases of django, and OpenTreeMap needs ... push RobinIsTheBird travis-ci pending completion  
2988 rtb/hstore update HStore - multichoice fixes Changes ------- - The web GUI expects empty multichoice to look like an empty list. Put the fix in `form_extras` rather than deep in the `udf` code. - Delete a multichoice item whose list is empty - In `treemap... push RobinIsTheBird travis-ci pending completion  
2982 rtb/hstore update HStore - fix api The iOS app sends udf keys with value None for scalar udfs that are not in the `udfs` field. Handle it. Also fix `in` semantics for `UDFDictionary`. -- Connects to #1968 push RobinIsTheBird travis-ci pending completion  
2979 rtb/hstore update HStore - respond to comments Access and search now work for udfs with NULL choice values. Fix UDFModel udf cleaning to return all the errors. -- Connects to #1968 push RobinIsTheBird travis-ci pending completion  
2974 rtb/hstore update HStore remove commented-out line push RobinIsTheBird travis-ci pending completion  
2972 rtb/hstore update HStore Tolerate NULL hstore values push RobinIsTheBird travis-ci pending completion  
2965 rtb/hstore update HStore - review comments Changes ------- - Fix comment type-o in `importer.tests` - Improve comments in `test_udfs` explaining the need for a typecast Transform in a comparison search - Remove vestigial `dfd ` param and `deepcopy` from ... push RobinIsTheBird travis-ci pending completion  
2963 rtb/hstore update HStore - fix for migration Changes ------- - Fix `UDFDictionary.__repr__` to tolerate a missing instance for the sake of reverse migration -- Connects to #1968 push RobinIsTheBird travis-ci pending completion  
2959 rtb/hstore update HStore - review comments Changes ------- - `treemap.udf` - Revert `treemap.udf.UDFModel` to using `udfs` as a `Field` - Name the field `UDFPostgresField` because of instructions in https://docs.djangoproject.com/en/1.11/howto/c... push RobinIsTheBird travis-ci pending completion  
2952 rtb/hstore upgrade HStore Overview -------- The point of this commit is to switch from `django_hstore.fields.DictionaryField` to `django.contrib.postgres.fields.HStoreField`. The former is incompatible with later releases of django, and OpenTreeMap needs ... push RobinIsTheBird travis-ci pending completion  
See All Builds (2530)