OpenTreeMap / otm-core / 2959
84%
develop: 84%

LAST BUILD BRANCH: dependabot/npm_and_yarn/sockjs-0.3.21
DEFAULT BRANCH: develop
Ran
Jobs 1
Files 216
Run time 11s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2959

push

travis-ci

RobinIsTheBird 
update HStore - review comments

Changes
-------
- `treemap.udf`
  - Revert `treemap.udf.UDFModel` to using `udfs` as a `Field`
    - Name the field `UDFPostgresField` because of instructions in
      https://docs.djangoproject.com/en/1.11/howto/custom-model-fields/
      #changing-a-custom-field-s-base-class
    - Change all references to the `hstore_udfs__` lookup back to `udfs__`
    - Fix the Migration accordingly, which necessitated
      tolerating a `UDFDictionary` without an `instance` in
      `treemap.udf.UDFPostgresField.get_prep_value`
    - In the `UDFDictionary` produced by the `UDFPostgresField`,
      defer database-directed cleaning until save
    - A number of changes to tolerate dirt due to deferral to save
  - Update comments and docstrings to be consistent with the code.
  - Remove unused code vestiges
- Revert `treemap.views.map_feature` back to not checking for
  `ValidationError` when setting the attribute on the model
- Add documentatioon to `treemap.audit.UserTrackable` explaining
  `populate_previous_state`:
  - When it should be called
  - How to know it wasn't called when it should
  - Rationale for shifting the responsibility to leaf classes
- Restore readonly TODO comments
- Restore pending tests to `test_audit`
  - skip `test_pending_udf_audits` because the HStore update did not
    include implementing Pending for udfs.
  - Note that restoring the pending tests also restores
    `readonly` tests.
  - Several tests were already skipped from the permissions work
    last year, so at this point, pending audits has very few
    operational tests
- Remove 'WITHIN_RADIUS' from `treemap.search` docstrings.

--

Connects to #1968

17310 of 20742 relevant lines covered (83.45%)

0.83 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
97.94
 0.0% treemap/search.py
2
75.17
 -1.38% exporter/tasks.py
5
96.24
 0.0% importer/models/trees.py
15
77.69
 -0.27% treemap/views/map_feature.py
58
90.24
 -9.53% treemap/tests/test_audit.py
78
80.59
 3.75% treemap/audit.py
100
84.51
 1.5% treemap/udf.py
Jobs
ID Job ID Ran Files Coverage
1 2959.1 216
83.45
 Travis Job 2959.1
Source Files on build 2959
Coverage ∆ File Lines Relevant Covered Missed Hits/Line