OpenCHAMI / ochami / 41876918460

93%

push

github

fix!: make -d exclusive with flags and arguments (#237)

* fix(bss): let delete select by any one flag

bss boot params delete rejects a lone selector or a lone field, such
as --kernel, unless both kinds are passed. Its help, its own examples,
and ochami-bss(1) say any one of them is enough, which matches what
BSS accepts: delete by component or by boot config. The stricter rule
came from copying the add and set validator into delete.

Require at least one of the six flags instead, and list --params in
the ochami-bss(1) synopsis and description, which left it out.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

* refactor(bss): share boot params flag checks

The add, set, and update commands validate their flags with copies of
the same function, and delete repeats its -d handling, so a change to
that handling must be made in several places and can drift.

Use one validator for add, set, and update in fields.go, and move the
-d warning into a helper that delete's validator calls too. Add
cli.AnyFlagChanged to replace the anyChanged closure each copy
defines. Behavior does not change.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

* fix(bss)!: reject boot params flags with -d

With -d, the boot params add, set, update, and delete commands warn
"raw data passed, ignoring CLI configuration", then apply the flags
over the payload anyway, so the request carries values the user was
told were dropped.

Make the component and boot config flags mutually exclusive with -d,
so a request comes wholly from the payload or wholly from the flags.
The smd add commands already reject their field flags with -d, and an
exclusive rule needs no precedence between the two, which would be
unclear for a payload listing many items.

This drops the override that let a payload act as a template, such as
one file reused with a new --kernel. Edit the payload instead. Note
the restriction in the help text and ochami-bss(1), an... (continued)

216 of 218 new or added lines in 20 files covered. (99.08%)

13318 of 14266 relevant lines covered (93.35%)

743.21 hits per line