KusionStack / karpor
66%
main: 66%

LAST BUILD BRANCH: fix/pod-log-query-validation
DEFAULT BRANCH: main
Repo Added
Files 68
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/pod-log-query-validation
branch: SELECT
CHANGE BRANCH
x

coverage: 66.053% (-0.03%) from 66.082%
43066903481

Pull #880

github

NopeCharon 
fix(insight): reject invalid pod log filters instead of ignoring them

The pod log endpoint parsed the since, sinceTime and tailLines query
parameters but dropped any value it could not parse, then streamed the
logs as if no filter had been set. The log settings dialog makes this
easy to hit: its "Show logs since" field suggests "e.g. 1h, 2d", but
time.ParseDuration has no day unit, so entering "2d" silently returned
the last 1000 lines instead of the last two days.

Move the query parsing into buildPodLogOptions and make it return an
error for:

- a since value that is not a positive Go duration (for example "2d",
  "0s" or "-5m"). Sub-second durations are rounded up to 1s, because
  the Kubernetes API rejects sinceSeconds=0;
- a sinceTime value that is not an RFC3339 timestamp;
- a tailLines value that is not a non-negative integer.

GetPodLogs sends the error through the existing SSE error entry, which
the log viewer already shows as an alert, and does so before building
the cluster client. Valid requests produce the same PodLogOptions as
before.

The placeholder of the since field now shows supported values
("e.g. 5m, 1h, 48h"), matching the units accepted by kubectl logs
--since and the API docs of the endpoint.

Add table-driven tests for buildPodLogOptions covering the defaults for
streaming and download, valid and invalid since, sinceTime and
tailLines values, and since taking precedence over sinceTime.

Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>
Pull Request #880: fix(insight): reject invalid pod log filters instead of ignoring them

4553 of 6893 relevant lines covered (66.05%)

0.73 hits per line

Relevant lines Covered
6893 RELEVANT LINES 4553 COVERED LINES
0.73 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
43066903481 fix/pod-log-query-validation fix(insight): reject invalid pod log filters instead of ignoring them The pod log endpoint parsed the since, sinceTime and tailLines query parameters but dropped any value it could not parse, then streamed the logs as if no filter had been set. T... Pull #880 NopeCharon github
66.05
43066846105 feat/i18n-japanese feat(i18n): add Japanese language support Add Japanese (日本語) to the Web UI language switcher. Karpor already ships a Japanese README, but the UI itself could not be used in Japanese. - ui/src/locales/ja.json: the Japanese locale. It has all 220 ... Pull #879 NopeCharon github
66.05
43038455061 feat/topology-node-tooltip feat(ui): enrich topology graph node tooltips The topology node tooltip only printed the raw node id (or the GVK label in the cluster view), so users had to click through to learn anything about a node. Render the tooltip as a small card instead... Pull #878 NopeCharon github
66.08
43036457008 feat/topology-node-tooltip feat(ui): enrich topology graph node tooltips The topology node tooltip only printed the raw node id (or the GVK label in the cluster view), so users had to click through to learn anything about a node. Render the tooltip as a small card instead... Pull #878 NopeCharon github
66.08
42796149978 fix/validate-exec-kubeconfig fix(cluster): validate the current context and mask exec env in cluster objects Validation picked the first cluster and user of the kubeconfig, while creating the cluster goes through clientcmd and follows current-context. A multi-context kubecon... Pull #867 NopeCharon github
66.56
42742650943 main fix(cluster): support cluster endpoints without an explicit port (#869) ## What type of PR is this? /kind bug ## What this PR does / why we need it: In #819, the kubeconfig exported from vCluster Platform (server `https://xxxx/kubernetes/proje... push web-flow github
66.08
42630332294 fix/cluster-endpoint-without-port fix(cluster): support cluster endpoints without an explicit port Clusters whose API server URL has no port, such as Rancher or vCluster platform proxy URLs like https://example.com/k8s/clusters/c-xxxxx, cannot be used after registration. NewConfi... Pull #869 NopeCharon github
66.05
42533971881 fix/hf-top-p-c2075 fix(ai): pass --ai-top-p to the Hugging Face backend Signed-off-by: Alex Castillo <alex.castillog33@gmail.com> Pull #877 pcbeingused333 github
65.76
42371599401 fix/search-pagesize fix(search): honor pageSize=1 in the search API The handler treated any pageSize <= 1 as unset and replaced it with 10, so a client asking for a single result per page got ten. Only values below 1 are invalid; same guard for page. Pull #876 pcbeingused333 github
65.64
42347965157 main fix(ai): pass the configured top-p to the Azure OpenAI backend (#874) `--ai-top-p` is ignored by the Azure OpenAI backend: `AzureAIClient` never stores `cfg.TopP` and builds its requests (`Generate` and `GenerateStream`) with only `Temperature`. ... push web-flow github
65.61
See All Builds (734)