KusionStack / karpor

65%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 02-22-demo_fb33d3ef_add_activity_feed_api
• add-auto-milestone-summary-action
• add-community-plan-and-task-updater
• add-growth-to-planning-updater-ci
• add-ingress-watch
• add-japanese-readme-security
• add-missing-version-bump-in-badge
• add-new-contributor-Cookiery
• add-new-contributor-Cookiery-for-doc
• add-new-contributor-eltociear
• add-new-contributor-jinjiaKarl-for-code
• add-new-contributor-rajp152k
• add-new-contributor-wujunwei
• add-new-contributor-wujunwei-for-code
• add-yes-to-updater-ci
• addClusterLatency
• addPodStatus
• addPodStatusInSummary
• adjust-ai-panel-style
• adjust-milestone-planning-action
• adjust-milestone-planning-action-categories
• adjust-readonly-middleware-logic
• ai-analysis-dialog-show
• ai-analysis-pretty
• all-contributors/add-LeoSofl
• all-contributors/add-jinjiaKarl
• all-contributors/add-nueavv
• all-contributors/add-rajp152k
• auto/issue-735
• auto/issue-767
• chart-version-updater
• chore/optimize-makefile
• codex/karpor-796-ai-panel
• cursor/fix-markdown-link-check-c618
• cursor/fix-nilnil-search-test-5171
• dependabot/go_modules/github.com/go-chi/chi/v5-5.2.2
• dependabot/go_modules/github.com/sirupsen/logrus-1.9.1
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/net-0.33.0
• dependabot/go_modules/golang.org/x/oauth2-0.27.0
• enhance-metrics-exp-with-trend-charts
• event-ai-style
• event-ai-style-pretty
• feat-connect-control
• feat-ha-push
• feat-karpor-agent
• feat-karpor-agent-highversion
• feat/i18n-hindi
• feat/karpor-llm-api-proxy
• feat/locale-parity
• feat/status-cluster-syncregistry
• feat/support-wildcard-sync-strategy
• feat/yaml-refresh-sofl
• fix-404-username
• fix-event-tab
• fix-frontend-runtime-bug
• fix-golangci-lint-issues-again
• fix-jitter-when-log-reconnecting
• fix-md-lint
• fix-mk-lint
• fix-redundant-code-block
• fix-topology-graph-interactive
• fix-topology-interactive-1223
• fix-upgrading-nodeV23-build-error
• fix-wrong-app-version-when-update-chart
• fix/ai-default-model
• fix/ai-stream-goroutine-leak
• fix/huggingface-empty-response
• fixNLSearch
• fixStreamRbac
• korean
• main
• mcp-support
• misc-optimize
• optiServerConfig
• optimize-seo
• optimizeServerConfig
• pretty-ai-interpret-style
• pretty-ai-panel-style
• pretty-insight-add-mothod
• pretty-podlogs-style
• pretty-topology-graph
• refine-log-aggregator
• refine-readme
• remove-dry-run
• remove-internal-resources
• rename-community-planning-updater-action
• standardize-event-log-tab-names
• support-ai-based-event-dignosis
• support-ai-based-issue-interpret
• support-ai-based-log-dignosis
• support-ai-based-yaml-interpret
• support-default-model-when-backend-is-deepseek
• support-go-alias-in-makefile
• test/ui-playwright-e2e
• translate-readme-ko
• unify-isAIEnabled-usage
• update-demo-video
• update-milestone-summary-action
• update-planning-action-triggers
• update-readme-iter-instru
• update-zh-readme
• use-default-version-when-occur-error

Build # 39579317773

Build Type

push

github

Committed by web-flow

Commit Message

fix(ai): stop the stream goroutine when the context is cancelled (#866)

## What type of PR is this?

/kind bug

## What this PR does / why we need it:

`GenerateStream` of the OpenAI, Azure OpenAI and DeepSeek clients
(`pkg/infra/ai`) starts a goroutine that sends every chunk, and the
final `ERROR: ...` message, to a buffered channel (size 100) without
looking at `ctx`. If the consumer stops reading and cancels the context
(for example the HTTP client disconnected), the goroutine blocks forever
on the full channel and keeps the upstream HTTP response open.

This wraps the sends in a `select` on `ctx.Done()`, the same way the
Hugging Face client already does.

## Tests

New `pkg/infra/ai/stream_cancel_test.go`: a server streams 300 chunks
(more than the buffer), the consumer reads nothing and cancels the
context, and the test checks that the `GenerateStream` goroutine exits.
It runs for the three clients, fails on `main` for all three and passes
with the change. `gofmt`, `go vet` and `go test ./pkg/infra/ai/` are
clean (golang:1.26 container).

## Special notes for your reviewer:

This change was made with Claude Code.

Co-authored-by: elliotxx <951376975@qq.com>

Coverage Stats

12 of 21 new or added lines in 3 files covered. (57.14%)

5 existing lines in 4 files now uncovered.

4501 of 6902 relevant lines covered (65.21%)

0.72 hits per line