KusionStack / karpor / 42630332294

66%

main: 66%

Pull #869

github

fix(cluster): support cluster endpoints without an explicit port

Clusters whose API server URL has no port, such as Rancher or vCluster
platform proxy URLs like https://example.com/k8s/clusters/c-xxxxx,
cannot be used after registration. NewConfigFromCluster derives the TLS
server name with net.SplitHostPort(u.Host), which fails when the host
has no port:

    address example.com: missing port in address

so every client built for the cluster, and the cluster proxy, fails
with that error.

Use u.Hostname() instead, in both copies of NewConfigFromCluster
(pkg/infra/multicluster and the cluster proxy registry). It returns the
same host as before when a port is present, works without one and also
strips the brackets of IPv6 literals.

checkEndpointConnectivity, used when validating a kubeconfig, already
falls back to port 443, but built the address with
fmt.Sprintf("%s:443"), which is invalid for IPv6 hosts. Build it with
net.JoinHostPort instead.

Add tests for NewConfigFromCluster with and without a port, for IPv6
endpoints and for exec credentials, and check the address dialed by
checkEndpointConnectivity.

Fixes #819

Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>

2 of 2 new or added lines in 2 files covered. (100.0%)

4553 of 6893 relevant lines covered (66.05%)

0.73 hits per line