• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus
44%
main: 69%

Build:
Build:
LAST BUILD BRANCH: LC-1092
DEFAULT BRANCH: main
Repo Added 30 Jan 2023 08:19PM UTC
Files 532
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH feature/interactive-graph-editor
branch: feature/interactive-graph-editor
CHANGE BRANCH
x
Reset
  • feature/interactive-graph-editor
  • changeset-release/main
  • feature/analytics
  • feature/poc-render-single-column
  • feature/remove-input-number
  • main
  • refs/heads/feature/interactive-graph-editor
  • refs/heads/main

pending completion
5146671386

push

github

web-flow
Don't need `key` on GraphPointsCountSelector (#560)

## Summary:

Per Matthew's [comment](https://github.com/Khan/perseus/pull/555#discussion_r1212299226), we don't need `key` on elements unless they are in a list context.

Issue: LC-813

## Test plan:

`yarn start` -> Navigate to the Perseus Editor - Interactive Graph Demo and select the graph type "points"

Author: jeremywiebe

Reviewers: handeyeco

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald, ✅ finish_coverage, ✅ gerald, ⏭  Publish npm snapshot, ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/560

7227 of 16237 branches covered (44.51%)

Branch coverage included in aggregate %.

19972 of 45876 relevant lines covered (43.53%)

970.21 hits per line

Relevant lines Covered
Build:
Build:
45876 RELEVANT LINES 19972 COVERED LINES
970.21 HITS PER LINE
Source Files on feature/interactive-graph-editor
  • Tree
  • List 520
  • Changed 11
  • Source Changed 0
  • Coverage Changed 11
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
5146671386 feature/interactive-graph-editor Don't need `key` on GraphPointsCountSelector (#560) ## Summary: Per Matthew's [comment](https://github.com/Khan/perseus/pull/555#discussion_r1212299226), we don't need `key` on elements unless they are in a list context. Issue: LC-813 ## Test ... push 01 Jun 2023 04:12PM UTC web-flow github pending completion  
5146671990 feature/interactive-graph-editor Merge 47544651c into 5fba7c604 Pull #555 01 Jun 2023 04:11PM UTC web-flow github pending completion  
5146508019 feature/interactive-graph-editor Extract the weird, implicit numeric coercion + unlimited code to a properly tested function (#559) ## Summary: Matthew [noted(https://github.com/Khan/perseus/pull/555#discussion_r1212317182) in #555 that I'd brought back some code that was prett... push 01 Jun 2023 03:56PM UTC web-flow github pending completion  
5146508319 feature/interactive-graph-editor Merge 67f2b4598 into 5fba7c604 Pull #555 01 Jun 2023 03:56PM UTC web-flow github pending completion  
5138078206 feature/interactive-graph-editor Merge branch 'main' into feature/interactive-graph-editor push 31 May 2023 10:04PM UTC jeremywiebe github pending completion  
5138078510 feature/interactive-graph-editor Merge 183e6478f into 937d2308b Pull #555 31 May 2023 10:03PM UTC web-flow github pending completion  
5124037443 feature/interactive-graph-editor Merge d5012074a into 67f8f5462 Pull #555 30 May 2023 04:38PM UTC web-flow github pending completion  
5124031618 feature/interactive-graph-editor Merge d5012074a into 67f8f5462 Pull #555 30 May 2023 04:37PM UTC web-flow github pending completion  
5123956577 feature/interactive-graph-editor Move registerAllWidgetsAndEditorsForTesting back to editor.stories.tsx (the function lives in perseus-editor so its not easily from preview.js) push 30 May 2023 04:29PM UTC jeremywiebe github pending completion  
5085283334 feature/interactive-graph-editor Merge branch 'main' into feature/interactive-graph-editor push 25 May 2023 10:53PM UTC Jeremy Wiebe github pending completion  
See All Builds (1401)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc