• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 5146671386
44%
main: 69%

Build:
Build:
LAST BUILD BRANCH: LC-1092
DEFAULT BRANCH: main
Ran 01 Jun 2023 04:12PM UTC
Jobs 2
Files 520
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
5146671386

push

github

web-flow
Don't need `key` on GraphPointsCountSelector (#560)

## Summary:

Per Matthew's [comment](https://github.com/Khan/perseus/pull/555#discussion_r1212299226), we don't need `key` on elements unless they are in a list context.

Issue: LC-813

## Test plan:

`yarn start` -> Navigate to the Perseus Editor - Interactive Graph Demo and select the graph type "points"

Author: jeremywiebe

Reviewers: handeyeco

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald, ✅ finish_coverage, ✅ gerald, ⏭  Publish npm snapshot, ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/560

7227 of 16237 branches covered (44.51%)

Branch coverage included in aggregate %.

19972 of 45876 relevant lines covered (43.53%)

970.21 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
1 jest 5146671386.1 01 Jun 2023 04:20PM UTC 516
60.67
GitHub Action Run
2 cypress 5146671386.2 01 Jun 2023 04:12PM UTC 362
25.54
GitHub Action Run
Source Files on build 5146671386
  • Tree
  • List 520
  • Changed 11
  • Source Changed 0
  • Coverage Changed 11
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • 47544651 on github
  • Prev Build on feature/interactive-graph-editor (#5146508019)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc