Khan / perseus / 5146508019

44%

main: 69%

push

github

Extract the weird, implicit numeric coercion + unlimited code to a properly tested function (#559)

## Summary:

Matthew [noted(https://github.com/Khan/perseus/pull/555#discussion_r1212317182) in #555 that I'd brought back some code that was pretty obscure and dependended on several Javascript coercion rules.

So this PR extracts the two identical instances where we do this and creates a function to formalize the behaviour. I've also added tests to ensure it's working as we think it should. :fingers-crossed:

Issue: LC-813

## Test plan:

`yarn test`

Author: jeremywiebe

Reviewers: handeyeco

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ gerald, ✅ Extract i18n strings (ubuntu-latest, 16.x), ⏭  Publish npm snapshot, ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/559

7226 of 16237 branches covered (44.5%)

Branch coverage included in aggregate %.

19971 of 45877 relevant lines covered (43.53%)

970.56 hits per line