IJHack / QtPass
68%
main: 93%

DEFAULT BRANCH: main
Repo Added
Files 88
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 92.898% (-0.03%) from 92.924%
36411484084

push

github

web-flow 
PasswordDialog: keep the entry when saving it fails (#1951)

* PasswordDialog: keep the entry when saving it fails

The dialog closed as soon as OK was pressed and started the insert on its
way out; gpg ran after exec() had returned. When that failed (a missing
or expired recipient key, the empty .gpg-id of #1944, a refused path)
the error was shown and what was typed was gone.

accept() now starts the insert itself and stays open, fields and OK
locked, "Saving…" in the status line, until the backend reports:
- finishedInsert closes the dialog as accepted;
- the new Pass::insertFailed (emitted next to processErrorExit for a
  failed PASS_INSERT, as generateGPGKeysFailed is for key generation)
  unlocks the fields, which still hold the entry, and shows the reason;
- a refusal before anything starts comes through critical() during the
  Insert() call and is handled the same way.
A new entry that is on disk after a failure was written and only a later
git step failed; the dialog then closes and the main window reports git.
An existing entry OK'd before its decrypt arrived now leaves the dialog
open instead of closing without saving.

FieldLabel also consumes Enter: confirming a field rename used to reach
the dialog's default button and save and close the whole entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* PasswordDialog: wait out a pending save; the backend says what was written

Review follow-ups:
- Cancel, Esc and the window's close button are refused while an insert
  is in flight (reject() override, Cancel disabled): a failure after the
  dialog was gone had nothing left to hand back.
- The template box and Ctrl+T are locked while saving; another template
  would rebuild the field rows under the pending insert.
- "The file is there now" was no proof that this insert wrote it: another
  writer could create the name meanwhile. insertFailed() now carries
  `writ... (continued)

72 of 77 new or added lines in 7 files covered. (93.51%)

44 existing lines in 4 files now uncovered.

9065 of 9758 relevant lines covered (92.9%)

191.64 hits per line

Relevant lines Covered
9758 RELEVANT LINES 9065 COVERED LINES
191.64 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
36411484084 main PasswordDialog: keep the entry when saving it fails (#1951) * PasswordDialog: keep the entry when saving it fails The dialog closed as soon as OK was pressed and started the insert on its way out; gpg ran after exec() had returned. When that fai... push web-flow github
92.9
36048524480 main Settings pages read top to bottom; "Never" fits its box (#1931) * Settings pages read top to bottom; "Never" fits its box The settings pages put their checkboxes in two-column grids, so "push" sat beside ".gpg-id" and "pull" landed on the next r... push web-flow github
92.92
36043961469 main Theme switch: check the bars again when the switch reaches the window (#1930) After a KDE light/dark switch Breeze re-stamps the previous theme's header palette on the toolbar and the menu bar. #1874 drops that stamp from the bar's PaletteChange,... push web-flow github
92.92
36032882595 main Settings: the content panel gets a Display page of its own (#1929) The Clipboard page also carried "Content panel behaviour" (hide content, hide the password, panel autoclear, monospace, as-is, line wrapping), which has nothing to do with the cli... push web-flow github
92.91
36030464166 main Staged writes: place a new file where the filesystem has no hard links (#1928) Placing a staged file under a name that must not be taken used linkat(2) only: the one call every POSIX system has that fails with EEXIST instead of replacing. FAT and... push web-flow github
92.89
36026646180 main Hidden menu bar: Alt shows it, and the tray menu can turn it on (#1926) * Hidden menu bar: Alt shows it, and the tray menu can turn it on With the bar off (the default) Ctrl+M was the only way back, and nothing on screen said so once #1921 moved... push web-flow github
92.89
36016166901 main GpgIdGeneration::parse: take each header line in a helper (#1924) CodeFactor still scored parse() at 17 (lizard 14): the per-line generation/folder/unknown branches sat inside the loop. They move to a file-local takeHeaderLine() that returns the ... push web-flow github
92.98
36012989720 main Split the 10–14 band where a function did several jobs (#1923) * Split the 10-14 band where a function did several jobs After no function reached 15, 46 sat between 10 and 14. The grammar checkers among them (Base32, TOTP URI, WSL command, gpg c... push web-flow github
92.97
36006775383 main No function at cyclomatic complexity 15 or above (#1922) * No function at cyclomatic complexity 15 or above lizard puts eight functions at or over its warning line of 15. Each did several things in one body; each is now the sequence it was, with... push web-flow github
92.94
35998305302 main Settings: one control per choice (#1921) * Settings: one control per choice Clipboard and panel autoclear were a checkbox and a number each; they are a number each, where 0 reads "Never". "Use template" and "Show all fields templated" were two c... push web-flow github
92.93
See All Builds (2516)