ICRAR / ijson

100%

master: 100%

LAST BUILD ON BRANCH coverage-increase

branch: coverage-increase

CHANGE BRANCH

x

Reset

• coverage-increase
• async-fixes
• async-string-stream
• async_c
• bytes-prefix
• check-3.1.2.post0
• common_functions
• coros
• coverage-c
• decimal-c
• decoding-errors
• default_backend
• design_notes
• develop
• document-event-interception
• dump
• empty-members
• fixes-for-known-problems
• gh-actions
• ijson-dumps-multiple
• improved-readme
• issue-41
• issue-42
• issue-66
• items-and-kvitems-dont-join-path
• items_kwargs
• kvitems
• map_type
• master
• memory-leak
• more_tests
• new-devels
• no-tests-in-binary
• python-3.10
• python-parse-value-clarification
• python_multiple_values
• reader_conversion
• release-3.2.0
• rtobar-patch-1
• test
• test-comments
• test-module-rename
• test-wheels-on-travis
• toplevel_array
• travis-c-ext
• travis-more-python
• travis-xenial
• update-travis
• upload-check
• use_float
• v2.5
• v2.5.1
• v2.6.0
• v2.6.1
• v3.0
• v3.0.1
• v3.0.2
• v3.0.3
• v3.0.4
• v3.0rc1
• v3.0rc2
• v3.0rc3
• v3.1
• v3.1.1
• v3.1.2
• v3.1.2.post0
• v3.1.3
• v3.1.4
• v3.1.post0
• windows-wheels
• yajl109_test
• yajl2_c_parse_memleak
• zeros-python

Build # 232

Build Type

push

travis-ci-com

Committed by rtobar

Commit Message

Create builder_t objects on the stack, not heap

We previously created the builder separately on the heap. This process
involved memory allocations, which have a chance to fail, although in
our case it is very minimal. This small possibility however accounted
for some code that was missing coverage (because the error never
occurred).

This code changes how builder_t objects are managed, allocating its
memory together with the object that contains it (ItemsBasecoro and
KVItemsBasecoro). This in turn means we don't need to perform an extra
memory allocation, and therefore removing this uncovered code.

This change should also have some further improvements, as the builder's
memory resides closer potentially to the rest of its container object.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

1514 of 1517 relevant lines covered (99.8%)

369.2 hits per line