ICRAR / ijson

99%

master: 100%

LAST BUILD ON BRANCH common_functions

branch: common_functions

CHANGE BRANCH

x

Reset

• common_functions
• async-fixes
• async-string-stream
• async_c
• bytes-prefix
• check-3.1.2.post0
• coros
• coverage-c
• coverage-increase
• decimal-c
• decoding-errors
• default_backend
• design_notes
• develop
• document-event-interception
• dump
• empty-members
• fixes-for-known-problems
• gh-actions
• ijson-dumps-multiple
• improved-readme
• issue-41
• issue-42
• issue-66
• items-and-kvitems-dont-join-path
• items_kwargs
• kvitems
• map_type
• master
• memory-leak
• more_tests
• new-devels
• no-tests-in-binary
• python-3.10
• python-parse-value-clarification
• python_multiple_values
• reader_conversion
• release-3.2.0
• rtobar-patch-1
• test
• test-comments
• test-module-rename
• test-wheels-on-travis
• toplevel_array
• travis-c-ext
• travis-more-python
• travis-xenial
• update-travis
• upload-check
• use_float
• v2.5
• v2.5.1
• v2.6.0
• v2.6.1
• v3.0
• v3.0.1
• v3.0.2
• v3.0.3
• v3.0.4
• v3.0rc1
• v3.0rc2
• v3.0rc3
• v3.1
• v3.1.1
• v3.1.2
• v3.1.2.post0
• v3.1.3
• v3.1.4
• v3.1.post0
• windows-wheels
• yajl109_test
• yajl2_c_parse_memleak
• zeros-python

Build # 159

Build Type

push

travis-ci-com

Committed by rtobar

Commit Message

Reintroduce common.* functions

This commit re-introduces the common.* functions that were removed
during the redesign of ijson 3. In ijson 2.X these functions were the
building blocks over which the backend-specific functions were built
upon. However, with the redesign of the library in version 3 they were
not needed anymore and they were removed.

It turns out users around the globe used these methods, as they iterated
over events in ways we didn't anticipate. Thus, there is value in adding
these functions back, even if it's not in a fully-performant way. With
time we can think of moving these functions into each backend so they
use the backend's underlying function, which is important for
performance.

Tests have been added to double-check that the behavior is the expected
one. In the case of items and kvitems we event skip through a few events
before reading the rest, which cannot be safely done with parse, as its
state machine depends on reading all events in order.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

1339 of 1351 relevant lines covered (99.11%)

239.6 hits per line