Freegle / Iznik

72%

master: 72%

LAST BUILD ON BRANCH fix/patchuser-silent-settings-write-9923

branch: fix/patchuser-silent-settings-write-9923

CHANGE BRANCH

x

Reset

• fix/patchuser-silent-settings-write-9923
• chore/api-surface-audit
• chore/coverage-adapter
• chore/coverage-amp
• chore/coverage-app-release-classifier
• chore/coverage-dashboard-go
• chore/coverage-database
• chore/coverage-donations-helpers
• chore/coverage-emailtracking
• chore/coverage-embedding
• chore/coverage-export
• chore/coverage-handler
• chore/coverage-image
• chore/coverage-isochrone
• chore/coverage-merge
• chore/coverage-misc
• chore/coverage-namegen
• chore/coverage-reusebenefit
• chore/coverage-sentrylog
• chore/coverage-sso
• chore/coverage-team
• chore/coverage-use-blur-detector
• chore/coverage-use-distance
• chore/coverage-use-suppress-exception
• chore/coverage-use-typewriter
• chore/coverage-useTimeFormat
• chore/coverage-useTwem
• chore/coverage-utils
• chore/coverage-utils-flex-json
• chore/coverage-vectorsearch-20260422
• chore/coverage-worrywords-edge-cases
• chore/drop-ip-abuse-worries
• chore/gitattributes-linguist
• chore/gitignore-eee-runtime-artifacts
• chore/outreach-attachments-donation-tests
• chore/pr-template
• chore/pr-uncommitted-hook
• chore/prune-plan-crud
• chore/purge-email-tracking-30d
• chore/remove-doodle-logos
• chore/remove-iznik-server
• chore/remove-matomo
• chore/remove-retired-status-container
• chore/remove-sentry-autofix-tool
• chore/remove-v1v2-parity-tooling
• chore/salvage-orphaned-wip
• chore/skip-iznik-server-ci-tests
• ci/spatial-tests-serial
• cleanup/retire-cake-for-mods
• cloud-hostgw-fix
• coverage/Go-tdd
• coverage/event-filtering-tests
• coverage/go-1714999056
• coverage/go-status-readgithead-2026-04-29
• coverage/go-tryst-20260503
• coverage/laravel-gemini-service-20260504
• coverage/laravel-message-commands-2026-05-02
• coverage/useModMessages-uncovered-branches-1777447042
• coverage/vitest-uppy-retry-coalescer-2026-05-07
• coverage/vitest-use-trace-20260425
• diagnose/repost-group-change-dom-dump
• docs/frontend-server-migration-plan
• docs/pr-discourse-link-standard
• docs/reach-evidence-and-monitor-scripts
• docs/revamp
• feat/admin-previous-fix
• feat/android-app-shortcuts
• feat/api-deprecation-observe
• feat/app-native-features
• feat/archive-attachments
• feat/batch-log-rotation
• feat/batch-migrate-non-email-jobs
• feat/batch-migrate-remaining-scripts
• feat/birthday-emails
• feat/browse-scroll-instrumentation
• feat/bulk-offer-external-update-link
• feat/chat-chaseup-mods
• feat/chat-compose-draft-persistence
• feat/chat-review-notify
• feat/chat-review-pending
• feat/chitchat-thread-navigation
• feat/connectivity-friction-isochrone
• feat/contentcheck-pipeline
• feat/deprecate-apiv2-audited-endpoints
• feat/digest-reply-notice
• feat/distance-pref-settings-email
• feat/distance-preference-outbound-and-frontier
• feat/donations-daily-summary
• feat/engage-emails
• feat/events-digest
• feat/group-customisation
• feat/group-list-show-3-plus-more
• feat/groups-closed-reminder
• feat/groups-no-messages
• feat/haptics-feedback
• feat/helper-concierge-agent
• feat/hold-web-replies-out-of-reach
• feat/jobs-followup-modal
• feat/jobs-index-drift-rebuild
• feat/location-resolve-placename-search
• feat/lovejunk-tn-invoice
• feat/microvolunteering-notify
• feat/mod-active-welfare
• feat/modtools-capacitor-app
• feat/modtools-groupselect-work-colours
• feat/nearby-towns-under-distance-slider
• feat/newsfeed-mod-notif
• feat/noticeboard-thank-email
• feat/pageview-instrumentation
• feat/partnerships-restructure
• feat/postcode-please-choose
• feat/ripple-member-reach-gate
• feat/ripple-poster-membership-on-rippled
• feat/ripple-reachable-gate-batch
• feat/ripple-reachable-node-gate
• feat/ripple-reply-saturation-stop
• feat/ripple-retire-pending-on-take
• feat/ripple-retract-on-origin-removal
• feat/ripple-sysadmin-page-focus
• feat/rippling-analytics-progressive-drivetime
• feat/rippling-autoapprove-kpi
• feat/rippling-dashboard-cohorts
• feat/rippling-reply-attribution
• feat/rippling-trial-stats
• feat/share-into-freegle
• feat/share-into-freegle-ios
• feat/spatial-remove-expanding-bbox
• feat/spatial-routing-ui-yesterday
• feat/stories-ask
• feat/stories-to-central
• feat/tn-names-fix
• feat/tryst-calendar-reminders
• feat/user-support-dump
• feat/voice-posting-prototype
• feat/voicepost-actually-post
• feat/volunteering-digest
• feat/welcome-review
• feature/ai-image-prompt-improvements
• feature/ai-image-regen
• feature/ai-support-helper-rebuild
• feature/android-coldstart-safe
• feature/app-out-of-date-message
• feature/authority-stats-artisan
• feature/authority-stats-email
• feature/autoapprove-delay
• feature/batch-deadlock-fixes
• feature/batch-deadlock-fixes-v2
• feature/batch-jobs-dry-run-and-fixes
• feature/bounce-users-suspension
• feature/bulk-offer-clearance
• feature/bulk-offer-management
• feature/cansubmit-messagevalid
• feature/charity-badge
• feature/chat-api-test-coverage
• feature/chat-button-modifier-keys
• feature/chat-expected-migration
• feature/chat-process-migration
• feature/chat-spam-migration
• feature/check-spammers-migration
• feature/cloudflare-ai-images
• feature/cls-improvements
• feature/community-news
• feature/compose-single-call-rework
• feature/concern-keywords
• feature/coverage-20260429
• feature/coverage-laravel-event-listeners
• feature/coverage-message
• feature/coverage-postcode-remapping
• feature/coverage-vitest-1777133352
• feature/coverage-vitest-20260504
• feature/daily-posts-push
• feature/digest-relevance
• feature/donations-bulk
• feature/eee-identification
• feature/enable-batch-jobs
• feature/engage-update-migration
• feature/explore-mobile-finder
• feature/exports-migration
• feature/frontend-design-refresh
• feature/giftaid-chaseup-migration
• feature/go-coverage-group
• feature/go-coverage-pr
• feature/hybrid-embedding-search
• feature/jobs-placement-tracking
• feature/leave-freegle-notice
• feature/memberships-process-migration
• feature/message-search-index-migration
• feature/migrate-http-endpoints
• feature/mobile-feel
• feature/mod-notifs-migration
• feature/mod-report-multi-group
• feature/modtools-edit-origin-group
• feature/modtools-mod-mail-logging-9518
• feature/monitor-fsm-process-quality
• feature/monitor-fsm-sqlite
• feature/multi-group-messages
• feature/multi-group-messages-join
• feature/nearby-reach-flip
• feature/notification-chaseup-email
• feature/pinned-posts
• feature/putmessage-item-validation
• feature/reengagement-mails
• feature/reply-to-chat
• feature/report-chat-no-common-group
• feature/restore-vitest-status-endpoint
• feature/retire-keyword-search
• feature/retire-subject-line-settings
• feature/ripple-reach-map
• feature/rippled-post-home-group-first
• feature/rippling-browse
• feature/rippling-held-replies
• feature/rippling-immediate-mails
• feature/rippling-location-velocity
• feature/rippling-mod-location-changes
• feature/rippling-mod-ui
• feature/rippling-reach-engine
• feature/rippling-relax-seen-threshold
• feature/rippling-secondary-reject
• feature/rippling-self-tuning
• feature/rippling-single-group-posting
• feature/rippling-tighten-spam-checks
• feature/search-filter-tests
• feature/search-relevance-fix-9585
• feature/session-settings-defaults
• feature/similar-posts
• feature/social-login-profile-pictures
• feature/spatial-improvements
• feature/tdd-coverage-changes-endpoint
• feature/test-go-location-isochrones
• feature/unified-digest-revision
• feature/users-modmails-migration
• feature/vector-search
• feature/vector-search-default
• feature/vite8-build-speed
• feature/volunteering-maintenance
• feature/wanted-offer-match
• feature/wire-concern-keywords
• fix-295
• fix/abtest-coverage-determinism
• fix/add-member-409
• fix/ai-image-multi-item-9630-53
• fix/ai-image-test
• fix/ai-images-9646-1
• fix/app-photo-upload-9900-13
• fix/approved-members-infinite-scroll
• fix/auth-userlist-non-array-crash
• fix/authmw-session-read-after-write-9893
• fix/authority-autocomplete-crash
• fix/auto-repost-excessive-9481
• fix/auto-repost-missing-items-9481
• fix/autorepost-skips-removed-membership
• fix/banned-members-pagination-test
• fix/banned-no-post-digest
• fix/birthday-email-inactive-mods
• fix/block-vague-item-yes
• fix/browse-filter-ui-tweaks
• fix/browse-held-reach-filter
• fix/browse-hide-own-rejected
• fix/browse-scroll-debounced-session
• fix/browse-time-label-rippled
• fix/browseview-null-scan
• fix/bulk-offer-availability-display
• fix/bulk-offer-stats-per-item
• fix/bulk-register-hydration-race
• fix/chat-delivery-9800-1
• fix/chat-draft-persist-9884-2
• fix/chat-notifications-closed-blocked
• fix/chat-notify-ooo-autoreply
• fix/chat-phone-warning-false-positive-9518
• fix/chat-render-system-message
• fix/chat-review-message-merge
• fix/chitchat-deeplink-depth
• fix/chitchat-image-size-9749-5
• fix/chitchat-ios-cardinality
• fix/chitchat-ios-limited-posts
• fix/chitchat-reply-dots-padding-9749
• fix/chitchat-reply-optimistic
• fix/chitchat-scroll-centre
• fix/chitchat-scroll-history
• fix/ci-clear-stale-status-labels
• fix/ci-composer-install-retry
• fix/ci-npm-install-retry
• fix/compose-clear-and-start-over-9915
• fix/concierge-autoack-bounce
• fix/config-9793-5
• fix/config-standard-message-save-button
• fix/content-moderation-9620-283
• fix/daily-digest-badge-9806
• fix/db-read-split-read-your-writes
• fix/deploy-prod-apiv2-verify-race
• fix/digest-action-links-9786-25
• fix/digest-amp-tracking
• fix/digest-came-and-went-dedup
• fix/digest-clicks-chart-clarity
• fix/digest-clicks-daily-only
• fix/digest-first-posted-repost
• fix/digest-immediate-inactivity-window
• fix/digest-summary-outlook-br-9363-31
• fix/digest-wanted-no-image-wait
• fix/direct-chat-duplicate-9913-1
• fix/discourse-rate-limit-retry
• fix/donations-paypal-9810
• fix/duplicate-link-collection
• fix/eee-browser-submitting-flag
• fix/email-9363-29
• fix/email-photo-no-reply-modal
• fix/email-preheaders-ripple-intro
• fix/email-rendering-9363-31
• fix/email-tracking-images-loaded-hotrow
• fix/email-tracking-sent-at-index-name
• fix/enforce-discourse-quote-hook
• fix/event-email-images-broken-url
• fix/exclude-location-triggers-postcode-remap
• fix/external-da-pointer-events-block-clicks
• fix/file-sync-self-heal-bind-mounts
• fix/fsm-coverage-gate-exhausted-prs
• fix/gradle-plugin-portal
• fix/group-config-editing-9793-8
• fix/group-contact-label-9643-1
• fix/group-icon-missing-image-shows-logo
• fix/group-list-onhere-platform-flags
• fix/index-vue-onserverprefetch-deterministic-coverage
• fix/insert-then-select-id
• fix/ios-nse-wiring-absolute-path
• fix/ip-abuse-warning-9768-5
• fix/job-click-user-attribution
• fix/jobimg-9630-6
• fix/jobmodeltest-jobs-lock-wait
• fix/jobmodeltest-spatial-teardown-flake
• fix/jobs-dedup-and-distance
• fix/jobs-stale-knn-sync
• fix/katapult-reaper-zombie-fallback
• fix/laravel-coverage-determinism
• fix/location-9481-585
• fix/log-account-reinstatement
• fix/log-history-group-filter-9672-3
• fix/lostpw-typed-email-and-bounce-banner
• fix/lovejunk-tn-invoice-never-sent
• fix/member-deletion-status
• fix/member-review-ignore-noop-9618
• fix/member-seen-on-many-groups-review
• fix/merge-api-return-logins-v1-parity
• fix/message-create-lastinsertid
• fix/message-log-historical-name
• fix/message-log-historical-subject
• fix/message-summary-eager-image-loading
• fix/messagelist-crosspost-dedup-9733-7
• fix/microvol-badge-list-9856-9
• fix/microvol-renotify-9856
• fix/microvolunteer-count-refresh
• fix/microvolunteering-9856-3
• fix/microvolunteering-9856-4
• fix/microvolunteering-badge-9856-4
• fix/missing-received-logs
• fix/mod-admin-send-pending-400
• fix/modconfig-404-v1-parity
• fix/moderation-rippling-9890-1
• fix/modlog-historical-blank-and-auto-approved-label
• fix/modlog-self-delete-label
• fix/modlogs-dedup
• fix/modmail-log-pending-subject-9518-211
• fix/modmail-log-test-9518
• fix/modnotif-chitchat-clarity-avatar
• fix/modtools-alsoon-wording
• fix/modtools-backtopending-explanation
• fix/modtools-badge-count-9654-19
• fix/modtools-banned-pagination-9518-246
• fix/modtools-chat-badge-stuck
• fix/modtools-chat-name-9719-1
• fix/modtools-chat-review-hover-reveal
• fix/modtools-chat-review-member-details
• fix/modtools-chat-review-member-details-9518-219
• fix/modtools-config-9793-1
• fix/modtools-deleted-message-log-9622
• fix/modtools-duplicate-highlight-9518-341
• fix/modtools-edit-count-rippled-in
• fix/modtools-edits-backup-group-leak
• fix/modtools-email-branding
• fix/modtools-feedback-scroll
• fix/modtools-images-badge-9630-44
• fix/modtools-infinite-scroll-pagination
• fix/modtools-ios-add-note-chat-review-9518-234
• fix/modtools-keyword-colour
• fix/modtools-login-port-assertion
• fix/modtools-mapping-dpa-and-area-vertices
• fix/modtools-member-history-9672-3
• fix/modtools-member-review-buttons
• fix/modtools-member-search-hang
• fix/modtools-member-settings-toggle-9923
• fix/modtools-members-9518-238
• fix/modtools-members-9518-238-modmail-filter-test
• fix/modtools-members-9518-238-work
• fix/modtools-members-9518-239
• fix/modtools-photo-permissions
• fix/modtools-postcode-edit-iphone-ui
• fix/modtools-reject-standard-message-chat-9862-13
• fix/modtools-related-members-9631-16
• fix/modtools-related-members-9631-19
• fix/modtools-related-members-flash-and-filter
• fix/modtools-reported-post-no-reload-per-group
• fix/modtools-rippling-pending-9812-3
• fix/modtools-search-rippled-origin-group
• fix/modtools-session-relogin-9893-1
• fix/modtools-stdmsg-9644-1
• fix/modtools-stdmsg-group-9862-15
• fix/modtools-stdmsg-reject-chat-record-9862
• fix/modtools-stdmsg-reject-scope-9862-16
• fix/modtools-tn-listing-readonly
• fix/monitor-bugs-batch
• fix/mt-calendar-icon-padding
• fix/mt-chat-draft-saving
• fix/mt-duplicate-highlight-9518
• fix/mt-stdmsg-autogrow-boxes
• fix/mygroups-browse-count
• fix/myposts-donation-dismiss
• fix/myposts-old-posts-pinned-by-room-chat-9481-583
• fix/myposts-old-rejected-9481-583
• fix/national-volunteers-v2-parity
• fix/notification-seen-cache
• fix/out-of-area-postcode-test
• fix/patch-message-groupid-draft
• fix/pending-app-9783-6
• fix/pending-message-visibility
• fix/pending-url-spam-collection
• fix/photos-vanished-9629
• fix/playwright-coverage-sourcefilter-exclusions
• fix/playwright-coverage-spinbutton-determinism
• fix/popular-posts-ripple-aware
• fix/post-creation-9788-28
• fix/post-summary-9783-7
• fix/post-validation-9788-32
• fix/post-warnings-9766-14
• fix/postcode-remap-connection-blip
• fix/postsummary-layout-9684-3
• fix/push-collage-skip-ai
• fix/qr-mod-only
• fix/queue-fatal-error-sentry
• fix/rate-app-ios-stub
• fix/reach-map-tile-label-clip-9808
• fix/read-replica-failover
• fix/reject-contentcheck-9815
• fix/rejected-message-item-when-no-locationid
• fix/related-members-9631-16
• fix/related-members-9642-1
• fix/related-members-counter-9631
• fix/related-members-counter-stuck-9631
• fix/related-members-deleted-filter
• fix/related-members-group-filter
• fix/reopen-closed-chat-on-message
• fix/reply-composer-send-visible
• fix/reply-cta-reachability
• fix/reply-draft-persistence
• fix/reply-eligibility-data-driven
• fix/reply-pane-photo-zoom
• fix/reply-statemachine-formref-race
• fix/repost-reminder-dedup-rippling
• fix/retire-unused-kudos
• fix/review-ignore-held-members
• fix/ripple-hold-direct-email-reply
• fix/ripple-inflated-post-counts
• fix/ripple-reject-notification-9904
• fix/ripple-rejoin-only-rippled
• fix/ripple-retraction-not-scope-gated
• fix/ripple-taken-marks-gone
• fix/rippling-browse-sort-and-slider
• fix/rippling-charts
• fix/rippling-contentcheck-test
• fix/rippling-drivetime-504-async-job
• fix/rippling-explorer-9808-56
• fix/rippling-held-hide-sender-badge
• fix/rippling-held-reply-hidden-from-recipient
• fix/rippling-outcome-check
• fix/route-vague-posts-to-pending
• fix/routing-exclude-toll-roads
• fix/scheduler-minute-drift
• fix/search-white-goods-relevance-9585-18
• fix/sentry-7384446789-merge-logins-forEach
• fix/sentry-7421179445-mymessage-repost-null
• fix/sentry-failed-to-fetch-image-freegletusd
• fix/sentry-ftutils-getinnerdimensions-null
• fix/sentry-ftutils-getplacementposition-nuxt3-ces
• fix/sentry-ignore-freestar-ftutils-null
• fix/sentry-ignore-notreadable-io
• fix/sentry-in-operator-error-undefined
• fix/sentry-leaflet-tooltip-nullmap-nuxt3-d7b
• fix/sentry-nuxt3-d45-filter-undefined-error
• fix/sentry-suppress-ad-stack-noise
• fix/session-id-lastinsertid
• fix/session-series-bigint
• fix/share-copy-payload-9901-3
• fix/site-title-badge
• fix/spammer-patch-preserve-reporter
• fix/spammer-v1-parity-unconfirmed
• fix/spatial-postcodes-centroid
• fix/spinbutton-confirm-coverage-flip
• fix/srvx-lockfile-0.11.22
• fix/stats-chart-types-and-ad-cssbind
• fix/stdmsg-delete-and-config
• fix/stdmsg-delete-config-9518
• fix/stdmsg-editable-body-tn-editlink
• fix/stdmsg-instruction-red
• fix/stdmsg-textarea-min-3-lines
• fix/stories-userid-crash
• fix/support-purge-queues-forget-task
• fix/test-failures-investigation
• fix/tn-crosspost-photo-scrape
• fix/tn-post-postcode-edit-revert-9908
• fix/upload-compressor-downscale
• fix/uppy-debounce-retry-all
• fix/uppy-retryall-async-rejection
• fix/v2-api-user-emails-message-postings
• fix/v2-patch-user-trustlevel-not-persisted
• fix/vector-keyword-whole-word
• fix/vector-search-keyword-boost
• fix/vector-search-subject-tier
• fix/vectorsearch-non-determinism-and-irrelevance
• fix/vectorsearch-threshold-white-goods
• fix/view-source-distinction
• fix/wanted-vague-item-catchalls
• fix/withdrawn-pending-soft-delete-403
• fix/worry-word-dedup-and-scope
• infra/batch-host-cgroup-slices
• infra/edge-images-tier-up
• master
• messages-multiple-groups
• monorepo/partnerships-page
• perf/browse-computed-filtering
• perf/email-stats-force-index
• perf/markseen-batch
• perf/modtools-messages-union-all
• perf/proximity-notes-negative-memo
• perf/ripple-density-heatmap-bench
• perf/ripple-reach-speedup
• plans/freegle-chat-flow
• pr-234
• pr-289
• pr988-assets
• production
• ripple/decouple-reach-mail
• skill/community-reuse-outreach
• skill/freegle-impact-report
• temp-rebase
• test-modspammer-crash-bug
• test/ai-image-regen-history
• test/auth-google-autoselect-coverage
• test/coverage-changes-handler
• test/coverage-chat-notifications
• test/coverage-go-auth-hashpassword
• test/coverage-go-group-create
• test/coverage-go-utils
• test/coverage-location-isochrone
• test/coverage-vitest-uppy-retry-coalescer-1777621557
• test/go-coverage-namevalidation-helpers
• test/group-mod-dismiss-403
• test/katapult-runner-e2e
• test/laravel-coverage-mail-helper
• test/message-package-coverage
• test/message-pure-coverage
• test/related-members-count-stale
• test/session-flexint-coverage
• tn-integration-refactor
• tn-posts-api
• tn-sync-port-testing
• tn-sync-port-testing-local
• wip/ch-routing-prototype
• wip/rippling-metrics-trial-scoping

Build # 27300

Build Type

Pull #1083

circleci

Committed by edwh

Commit Message

fix(apiv2): surface failed settings writes in PatchUser

The settings UPDATE in PatchUser ignored its db.Exec error, so a genuinely
failed write still returned 200 "Success" - a silent no-op is exactly how
"settings won't stick" reports hide. Check the error and return 500 instead.

Adds a test that a moderator editing a member's settings on a group they
moderate persists the change (guards the authorised mod-write path).

Note: the deliberate self-fallback for unauthorised cross-user edits is left
as-is (TestPatchUserSettingsNonModCannotUpdateOther specifies 200 + no change
to the other user); the 9923 "toggles don't stick" report was a separate
frontend value-reading bug.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rm8xqAcBsnaYWZkrp5KAMA

Pull Request Pull Request #1083: fix(apiv2): surface failed settings writes in PatchUser

Coverage Stats

13064 of 17217 branches covered (75.88%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 1 file covered. (60.0%)

136558 of 189646 relevant lines covered (72.01%)

37.88 hits per line