Freegle / Iznik / 27300

72%

master: 72%

Pull #1083

circleci

fix(apiv2): surface failed settings writes in PatchUser

The settings UPDATE in PatchUser ignored its db.Exec error, so a genuinely
failed write still returned 200 "Success" - a silent no-op is exactly how
"settings won't stick" reports hide. Check the error and return 500 instead.

Adds a test that a moderator editing a member's settings on a group they
moderate persists the change (guards the authorised mod-write path).

Note: the deliberate self-fallback for unauthorised cross-user edits is left
as-is (TestPatchUserSettingsNonModCannotUpdateOther specifies 200 + no change
to the other user); the 9923 "toggles don't stick" report was a separate
frontend value-reading bug.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rm8xqAcBsnaYWZkrp5KAMA

13064 of 17217 branches covered (75.88%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 1 file covered. (60.0%)

136558 of 189646 relevant lines covered (72.01%)

37.88 hits per line