FAIRmat-NFDI / sand

89%

main: 86%

LAST BUILD ON BRANCH sheet-edit-write

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• always-regenerate
• arbitrary-start-samples
• async-extract-gui
• audio-companion-with-audio
• audio-entry-url-from-ids
• clear-live-transcript
• collect-inputs
• dashboard-cookie-login
• dashboard-entry-point
• deepgram-keyterms
• deepgram-relay
• delete-input
• derived-entry
• derived-sheet-field-comments
• discard-recording
• entry-point
• expand-derived-entries
• experiments
• extract-action-pipeline
• extract-action-skeleton
• extraction-ignore-greetings
• extraction-runner
• fix-gemini-schemas
• generate
• hysprint
• hysprint-domain
• hysprint-experiment-info-out-of-service
• hysprint-sheet-store
• input-label
• inputs-list
• kit_lab
• links-new-gui
• live-transcript-gui
• live-transcript-toggle
• main
• misc-refactor
• nomad-api-generic-helpers
• nomad-api-refactor
• please-commands
• pretranscribed-audio
• read-asr-transcript
• readme-remove-url-table
• readme-rewrite
• record-layout
• record-note-layout
• reextract-delete-sheet-first
• reextract-stale-steps
• remove-heard-line
• request-plumbing
• resolve-sample-labels
• restore-nomad-sand-name
• retry-failed-upload
• sample-info-form
• samples-schema-fix
• session-split
• sheet-download
• sheet-edit-ingest
• sheet-edit-roundtrip
• sheet-edit-structure
• sheet-edit-write
• sheet-sidecar-guard
• sheet-upload
• solute-relative-amount
• split-app-js
• status-step-trace
• template-cleanup
• ui-sections
• voice-checks-fail-early
• voice-commands
• voice-eln-transcribe
• voice-mode
• whisper-live-transcript

Build # 39684960071

Build Type

Pull #103

github

Committed by yaruwangway

Commit Message

Address review: refuse what sand cannot compute exactly

Every case below either wrote a stale or wrong value, or crashed instead
of refusing:

- Formulas whose inputs the text leaves open (defined names, INDIRECT,
  OFFSET, table references) may read any cell; whole-row ranges are seen.
- Date cells are not edited (text would replace the date), and formulas
  over dates are refused instead of raising TypeError.
- Comparisons follow Excel across types: numbers < text < TRUE/FALSE.
- Array formulas: refused only when an edit feeds them; data tables
  feed on anything. Formulas on other sheets that point at the edited
  sheet are refused.
- Circular formulas are refused instead of recursing forever.
- Writes outside the sheet are refused before any cell is created.
- An empty text result is a valid stored result, not a missing one.
- Docstring names the real self-check; HEADER_ROW instead of 2; verify
  reuses the loaded original (4 workbook loads per write, not 6).

Pull Request Pull Request #103: Sheet editing: write cells, recompute dependent formulas, verify

Coverage Stats

747 of 797 new or added lines in 6 files covered. (93.73%)

2580 of 2886 relevant lines covered (89.4%)

0.89 hits per line