FAIRmat-NFDI / nomad-parser-plugins-simulation

62%

develop: 67%

LAST BUILD ON BRANCH fix/remove-mapping-annotation-contamination

branch: fix/remove-mapping-annotation-contamination

CHANGE BRANCH

x

Reset

Sync Branches

• fix/remove-mapping-annotation-contamination
• 10-add-github-copilot-instructions
• abinit-mapping-parser
• adapt-physicalproperty-changes
• add-mapping-annotations-util
• add-md-parser-guide-docs
• add-tests
• ams-mapping-parser
• backup/test-oasis
• crystal-mapping-parser
• develop
• ebb-mapping-playground
• extend-parsers
• fhiaims-mapping-parser
• fix-abinit-dos
• fix-commit
• fix-representation-schema
• fixes
• gaussian-parser
• gromacs-parser
• gromacs-parser-clean
• gromacs-parser_model-method
• lammps-parser
• lammps-parser_model-method
• lammps-parser_system-hierarchy
• mapping-guide-doc
• migrate-md
• migrate-nomad-parser-h5md
• molcas-parser
• octopus-mapping-parser
• orca-parser
• parser_testing_strategy
• patch-h5md-schema-init
• pyscf-parser
• qe-gipaw-parser
• quantum-espresso-mapping-parser
• quick-fix-mkdocs
• schema_update_convergence_targets
• test-oasis
• turbomole-parser
• update-add-representation-section
• update-dft-schema
• update-nomad-simulations-urls
• update_add_system_orbitals
• wannier90-mapping-parser

Build # 20825639128

Build Type

Pull #137

github

Committed by ndaelman-hu

Commit Message

Annotate VASP-specific inherited properties to prevent contamination

Instead of annotating base class properties (numerical_settings.Pseudopotential.name),
annotate VASP's inherited properties (Pseudopotential.name). This makes VASP immune
to annotation removal from other parsers.

When a subclass inherits properties, Python creates separate property objects in the
subclass namespace. Annotations on Pseudopotential.name are stored separately from
numerical_settings.Pseudopotential.name, preventing contamination.

All 42 parser tests now pass.

Pull Request Pull Request #137: Fix global mapping annotation contamination in parsers

Run Details

148 of 200 new or added lines in 6 files covered. (74.0%)

552 existing lines in 15 files now uncovered.

4302 of 6937 relevant lines covered (62.02%)

0.62 hits per line