FAIRmat-NFDI / nomad-parser-plugins-simulation / 20825639128

62%

develop: 67%

Build Type

Pull #137

github

Committed by ndaelman-hu

Commit Message

Annotate VASP-specific inherited properties to prevent contamination

Instead of annotating base class properties (numerical_settings.Pseudopotential.name),
annotate VASP's inherited properties (Pseudopotential.name). This makes VASP immune
to annotation removal from other parsers.

When a subclass inherits properties, Python creates separate property objects in the
subclass namespace. Annotations on Pseudopotential.name are stored separately from
numerical_settings.Pseudopotential.name, preventing contamination.

All 42 parser tests now pass.

Pull Request Pull Request #137: Fix global mapping annotation contamination in parsers

Run Details

148 of 200 new or added lines in 6 files covered. (74.0%)

552 existing lines in 15 files now uncovered.

4302 of 6937 relevant lines covered (62.02%)

0.62 hits per line