FAIRmat-NFDI / nomad-parser-plugins-simulation

70%

develop: 74%

LAST BUILD ON BRANCH scf-convergence-migration

branch: scf-convergence-migration

CHANGE BRANCH

x

Reset

Sync Branches

• scf-convergence-migration
• 10-add-github-copilot-instructions
• abinit-mapping-parser
• adapt-physicalproperty-changes
• add-fhiaims-kmesh
• add-mapping-annotations-util
• add-md-parser-guide-docs
• add-model-method-tests
• add-pseudopot-parsing
• add-tests
• add-yambo-parser
• ams-mapping-parser
• backup/test-data-normalization-fhiaims-2026-05-12
• backup/test-oasis
• crystal-mapping-parser
• dependabot/devcontainers/ghcr.io/devcontainers-contrib/features/ruff-2.0.0
• develop
• ebb-mapping-playground
• extend-parsers
• extend-yambo
• feature/add-nomad-file-parser-dependency
• feature/convergence-targets-migration
• feature/fhiaims-scf-convergence
• feature/fhiaims-scf-convergence-alvin
• fhiaims-mapping-parser
• fix-abinit-dos
• fix-commit
• fix-field-naming-collision-h5md
• fix-nmr-version
• fix-particle-cgbeadstate
• fix-qe-ruff-error
• fix-representation-schema
• fix/fhiaims-enable-energy-mapping
• fix/remove-mapping-annotation-contamination
• fix_workflow_recursion_h5md
• fixes
• gaussian-parser
• gromacs-add-missing-annotation
• gromacs-parser
• gromacs-parser-clean
• gromacs-parser_model-method
• gromacs-parser_model-method-JFR
• gromacs-parser_results
• gromacs_parse_system_hierarchy
• h5md-fix
• hotfix/abinit-convergence-fields
• init-parser-util
• lammps-parser
• lammps-parser_model-method
• lammps-parser_system-hierarchy
• make-h5md-machine-readable
• mapping-guide-doc
• metadata-extractor
• migrate-md
• migrate-nomad-parser-h5md
• minimal-orca-parser
• molcas-parser
• octopus-mapping-parser
• orca-parser
• parser_testing_strategy
• patch-h5md-schema-init
• pin-nmr-version
• pr-150
• pyscf-parser
• qe-gipaw-parser
• quantum-espresso-mapping-parser
• quick-fix-mkdocs
• refactor/idiomatic-vasp-pseudopotential-parsing
• rename-annotation.keys
• schema_update_convergence_targets
• test-data-normalization
• test-oasis
• turbomole-parser
• update-add-representation-section
• update-dft-schema
• update-nomad-simulations-urls
• update_add_system_orbitals
• wannier90-mapping-parser

Build # 23431579272

Build Type

Pull #151

github

Committed by ndaelman-hu

Commit Message

Use coulomb instead of elementary_charge for GUI compatibility

Change charge convergence unit from `elementary_charge` to `coulomb` to fix
GUI unit parser error. The GUI uses mathjs units which doesn't recognize
`elementary_charge` as a valid unit name.

**Error fixed:**
```
SyntaxError: Unit "elementary_charge" not found.
at parseInternal (src/components/units/common.js:313)
```

**Changes:**
- exciting parser: Use `ureg.coulomb` instead of `ureg.elementary_charge` for charge convergence threshold
- Test expectations: Update values from elementary_charge-based to coulomb-based

**Conversion factor:** `1 elementary_charge = 1.602176634e-19 coulomb`

All tests pass.

Pull Request Pull Request #151: Scf convergence migration

Coverage Stats

783 of 907 new or added lines in 25 files covered. (86.33%)

6492 of 9241 relevant lines covered (70.25%)

0.7 hits per line