ExpediaDotCom / adaptive-alerting
95%

Repo Added 18 Feb 2019 11:01AM UTC

Files 3

Badge

Embed ▾

LAST BUILD ON BRANCH master
branch: SELECT

CHANGE BRANCH
x

No branch selected

master

pending completion

Build # 1725

Build Type

push

travis-ci

Committed by

djsutho

Commit Message

Cleanup/detector manager (#382)

* Stop pushing non-anomalous metrics to the anomalies topic.

The point of the anomalies topic is to notify downstreams of anomalous
metrics, so it doesn't make sense to send non-anomalous metrics.

I've left logging non-anomalous metrics in place for now. It is unclear
whether we want to keep that (due to the volume), but that's a follow-up
discussion with the team.

In the KafkaAnomalyDetectorMapper, I replaced the JsonPojoSerde (output
value serde) with a MappedMetricDataJsonSerde, as the former is
deprecated. Behaviorally, the MMDJsonSerde returns null when
deserialization fails, instead of throwing an exception. This is in line
with the guidance here:

https://stackoverflow.com/questions/51136942/how-to-handle-serializationexception-after-deserialization

Finally, I added a few unit test cases and refactored the manager and
mapper a bit, mostly to clarify the stream processing logic in those two
components.

* Reestablished event publication.

Realized after previous commit that suppressing normal events will make it
difficult for downstream consumers to detect recovery. So I reinstated
that.

Still submitting the overall PR since there are additional tests,
refactorings and polishings.

* Updated to address PR comments

Run Details

296 of 310 relevant lines covered (95.48%)

639067.98 hits per line

Relevant lines Covered

310 RELEVANT LINES 296 COVERED LINES

639067.98 HITS PER LINE

Source Files on master

Detailed source file information is not available for this build.

Recent builds

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
1725	master	Cleanup/detector manager (#382) * Stop pushing non-anomalous metrics to the anomalies topic. The point of the anomalies topic is to notify downstreams of anomalous metrics, so it doesn't make sense to send non-anomalous metrics. I've left ...	push	13 Apr 2021 03:37AM UTC	djsutho	travis-ci	pending completion

See All Builds (1)

ExpediaDotCom / adaptive-alerting
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT

CHANGE BRANCH
x

No branch selected

master

CHANGE BRANCH
x

Relevant lines Covered

Source Files on master

Recent builds

ExpediaDotCom / adaptive-alerting 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master branch: SELECT CHANGE BRANCH x No branch selected master

CHANGE BRANCH x

Relevant lines Covered

Source Files on master

Recent builds

ExpediaDotCom / adaptive-alerting
95%

README BADGES
x

LAST BUILD ON BRANCH master
branch: SELECT

CHANGE BRANCH
x

No branch selected

master

CHANGE BRANCH
x