1725
95%

Ran 13 Apr 2021 03:37AM UTC

Jobs 1

Files 3

Run time 0s

Badge

Embed ▾

pending completion

Build # 1725

Build Type

push

travis-ci

Committed by

djsutho

Commit Message

Cleanup/detector manager (#382)

* Stop pushing non-anomalous metrics to the anomalies topic.

The point of the anomalies topic is to notify downstreams of anomalous
metrics, so it doesn't make sense to send non-anomalous metrics.

I've left logging non-anomalous metrics in place for now. It is unclear
whether we want to keep that (due to the volume), but that's a follow-up
discussion with the team.

In the KafkaAnomalyDetectorMapper, I replaced the JsonPojoSerde (output
value serde) with a MappedMetricDataJsonSerde, as the former is
deprecated. Behaviorally, the MMDJsonSerde returns null when
deserialization fails, instead of throwing an exception. This is in line
with the guidance here:

https://stackoverflow.com/questions/51136942/how-to-handle-serializationexception-after-deserialization

Finally, I added a few unit test cases and refactored the manager and
mapper a bit, mostly to clarify the stream processing logic in those two
components.

* Reestablished event publication.

Realized after previous commit that suppressing normal events will make it
difficult for downstream consumers to detect recovery. So I reinstated
that.

Still submitting the overall PR since there are additional tests,
refactorings and polishings.

* Updated to address PR comments

Run Details

296 of 310 relevant lines covered (95.48%)

639067.98 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1725.1	13 Apr 2021 03:37AM UTC	0	95.48	Travis Job 1725.1

ExpediaDotCom / adaptive-alerting / 1725
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1725

ExpediaDotCom / adaptive-alerting / 1725 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1725

ExpediaDotCom / adaptive-alerting / 1725
95%

README BADGES
x