DanGould / rust-payjoin

82%

master: 84%

LAST BUILD ON BRANCH session4/unify-short-id

branch: session4/unify-short-id

CHANGE BRANCH

x

Reset

Sync Branches

• session4/unify-short-id
• 24-name-audit
• 402-ref-audit
• 465-rm-relay-from-session-ctx
• access-control
• access-control-v2
• add-agents-md
• add-navigability-signposts
• additive-cli-features
• additive-danger-local-https
• ai-disclosure
• arc-sc
• async-standup-v2
• avoid-uih-naming
• bump-ohttp-relay-0.0.10
• bump-payjoin-0-21
• bump-payjoin-0.24.0
• bump-payjoin-cli-0-1-0
• bump-payjoin-directory-0.0.2
• check-fetch-status
• check-independent-features
• coderabbit-refine-exceptions
• coderabbit-review-drafts
• coderabbit-strip-noise
• complete-intourl
• contributing-readme
• directory-mod
• doc-contrib-test
• dont-set-path
• ensure-no-original-psbt-keypath
• errant-url-endpoint
• explicit-err-conversions
• feat/1314
• feat/async-standup
• ffi-msrv-1.85.0
• fix-dlh
• fix-flaky-prune-test
• fix-output-substitution-import
• fix-send-resume
• fix-standup-syntax
• fix-test-flakiness
• fix-uri-ext-case
• fix/402-ref-audit
• fix/402-typestate-docs
• fix/794-msrv-clippy
• fix/devshell-treefmt
• handle-post-err
• handle-recv-contribution-err-as-unavailable
• handle-v2-error
• handle-v2-error-generic
• hide-danger-local-https
• hide-pr-template-checklist
• into-url
• json-error
• lib-docs
• lint-1.85.0
• lint-docs
• master
• min-feerate-broadcast
• moddocs
• no-uni-mod-distinction
• ohttp-fallback
• ohttp-relay-intourl
• ohttp-reqs-refactor
• one-expiry-error
• only-try-preserving-privacy
• overnight/issue-1016
• overnight/issue-1258
• overnight/issue-1274
• overnight/issue-855
• payjoin-0.21.0
• payjoin-0.22.0
• payjoin-0.23.0
• payjoin-0.24.0
• payjoin-1.0.0-rc.0
• payjoin-1.0.0-rc.1
• payjoin-directory-0-0-1
• payjoin-directory-0.0.2
• persist-ohttp-keys
• persist-payjoin
• pjos-to-0
• poll-no-pause
• pr-checklist
• prepare-psbt-by-copy
• propagate-config-err
• receive-error-heirarchy
• recv-err
• recv-state-transition-objects
• refactor-receiver
• refactor-sender
• refactor-wantsfeerange
• reply-json
• req-impl-visibility
• seal-state-trait
• sep-receive-errors
• separate-receive
• separate-send-errors
• separate-send-versions-p1
• separate-send-versions-p2-v2
• service-docker-compose
• service-multi-listener
• session4/issue-1227
• session4/issue-1276
• session4/issue-1300
• session4/issue-1374
• session4/issue-749
• session4/standup-v2
• split-v1-psbt-contexts
• test-utils
• test-utils-no-bitcoind
• test-utils-redis-follow
• uniform-ohttp-payloads
• update-bip78
• url-no-idna
• v1-data-minimization
• v1-feature-flag
• v1-v2
• v1context-visibility
• workflow-build-deps

Build # 22572331174

Build Type

Pull #20

github

Committed by DanGould

Commit Message

Unify short_id_from_pubkey as HpkePublicKey method

Both send/v2 and receive/v2 computed the ShortId mailbox
identifier from an HpkePublicKey using identical SHA-256
logic. The receiver had a standalone function while the
sender inlined the computation with a TODO to unify.

Move the logic to HpkePublicKey::short_id() in hpke.rs
so both modules call the same method. This removes the
duplicated function and the TODO comment.

Pull Request Pull Request #20: Unify short_id_from_pubkey as HpkePublicKey method

Run Details

7 of 7 new or added lines in 3 files covered. (100.0%)

10618 of 12874 relevant lines covered (82.48%)

409.96 hits per line