DanGould / rust-payjoin / 12537462827

61%

master: 84%

Build Type

push

github

Committed by DanGould

Commit Message

Make _danger-local-https feature additive

Instead of feature gating function params, which introduces the need for
similar feature gating in downstream code, feature gate individual
functions.

See: <https://doc.rust-lang.org/cargo/reference/features.html#feature-unification>

"Rust features should be *additive*. That is, enabling a feature should
not disable functionality, and it should usually be safe to enable any
combination of features"

Before this change `io::fetch_ohttp_keys` had two function signatures
and changed its signature based on the feature flag. I noticed downstream
that this creates a necessity to carry those flags mess into bindings
or else face compile issues under certain feature combinations.

`io` now enables the `v2` feature since it only contains methods for
fetching OHTTP keys which is only useful in V2. In the future perhaps
it will also include generic HTTP client behavior taking `Request` as
a parameter in which case it should not enable `v2`, because such
functionality would be useful in a V1 setting as well.

Run Details

7 of 16 new or added lines in 2 files covered. (43.75%)

15 existing lines in 1 file now uncovered.

2882 of 4695 relevant lines covered (61.38%)

974.53 hits per line