AfterShip / clickhouse-sql-parser
52%
master: 52%

LAST BUILD BRANCH: sharad/fix-rmv-column-list-engine
DEFAULT BRANCH: master
Repo Added
Token F4x2H6fmkWoZPkof5HTWcZ5HSIXKiqDLa regen
Build 468 Last
Files 15
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/keyword-as-column-in-select
branch: fix/keyword-as-column-in-select
CHANGE BRANCH
x
Sync Branches

coverage: 51.621% (+0.2%) from 51.469%
25677835255

Pull #269

github

erezrokah 
Accept bare keyword as last/only SELECT item

Extend keyword-as-identifier handling to recognize end-of-statement
(EOF or `;`) as a disambiguator in expression position, so projections
like `SELECT case`, `SELECT case;`, or `SELECT limit` parse as bare
column refs — matching ClickHouse server (verified against 25.10.7.6,
which returns UNKNOWN_IDENTIFIER, i.e. syntactic accept).

The eos check is applied inline in parseColumnExpr rather than added to
keywordIsSelectItemIdentifier, because the latter is shared with the
terminator/alias-position check, where a trailing clause-starter
keyword at EOF (e.g. `SELECT * FROM`) must still be treated as a
terminator. Verified `SELECT * FROM` still errors as before.

Fixtures:
- select_keyword_as_only_column.sql        (`SELECT interval`)
- select_keyword_as_only_column_semicolon  (`SELECT case;`)
- select_clause_keyword_as_only_column     (`SELECT limit`)
- select_keyword_as_alias                  (`SELECT 1 AS interval, 2 AS from, 3 AS limit`)

The AS-alias fixture documents that `SELECT 1 AS <reserved-kw>` already
works for every reserved keyword without special handling, because
matchTokenKind(TokenKindIdent) coerces TokenKindKeyword and so
parseIdent accepts keyword tokens as alias names; added a comment at
the AS branch of parseSelectItem to make that intentional.
Pull Request #269: fix: Allow reserved keywords as bare column names in SELECT list

43 of 43 new or added lines in 1 file covered. (100.0%)

8247 of 15976 relevant lines covered (51.62%)

2990.69 hits per line

Relevant lines Covered
15976 RELEVANT LINES 8247 COVERED LINES
2990.69 HITS PER LINE
Source Files on fix/keyword-as-column-in-select

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25677835255 fix/keyword-as-column-in-select Accept bare keyword as last/only SELECT item Extend keyword-as-identifier handling to recognize end-of-statement (EOF or `;`) as a disambiguator in expression position, so projections like `SELECT case`, `SELECT case;`, or `SELECT limit` parse as... Pull #269 erezrokah github
51.62
25673523884 fix/keyword-as-column-in-select fix: Allow reserved keywords as bare column names in SELECT list Pull #269 erezrokah github
51.58
25670782882 fix/keyword-as-column-in-select Extract clauseStarterKeywords as single source of truth Address Copilot review: the clause-starter list was duplicated between isSelectItemTerminatorKeyword's switch and peekIsClauseStarterKeyword's slice, with a real risk of drift. Extract the s... Pull #269 arifdemirel github
51.58
25668989343 fix/keyword-as-column-in-select Broaden bypass to all keywords and extend parseColumnExpr lookahead Empirically validated against ClickHouse server 25.10.7.6: CH accepts every reserved keyword as a bare column reference in SELECT projections except NOT (a unary operator). Teste... Pull #269 arifdemirel github
51.54
25668356849 fix/keyword-as-column-in-select Restrict bypass to LIMIT/OFFSET/FORMAT/SETTINGS to preserve trailing-comma-before-keyword-table handling Address review feedback: previous lookahead applied to all clause-starter keywords, which regressed parsing of `SELECT a, FROM `limit`` (trai... Pull #269 arifdemirel github
51.53
25667928751 fix/keyword-as-column-in-select Fix should treat LIMIT/OFFSET/FORMAT as columns in SELECT list when followed by `,`, AS, or another clause keyword Mirrors PR #268: extend `isSelectItemTerminatorKeyword` to peek the next token. A clause-starter keyword (LIMIT, OFFSET, FORMAT, SE... Pull #269 arifdemirel github
51.51
See All Builds (468)

Badge your Repo: clickhouse-sql-parser

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh