AfterShip / clickhouse-sql-parser / 25668356849

52%

master: 52%

Build Type

Pull #269

github

Committed by arifdemirel

Commit Message

Restrict bypass to LIMIT/OFFSET/FORMAT/SETTINGS to preserve trailing-comma-before-keyword-table handling

Address review feedback: previous lookahead applied to all clause-starter
keywords, which regressed parsing of `SELECT a, FROM `limit`` (trailing
comma before FROM where the next ident is itself a clause keyword).
Restrict the special-case to the four keywords that legitimately appear
as bare column names. FROM/WHERE/GROUP/ORDER/etc. stay unconditional
terminators so PR #268 trailing-comma handling is preserved.

Adds regression fixture select_trailing_comma_before_from_keyword_table.sql.

Pull Request Pull Request #269: fix: Allow LIMIT/OFFSET/FORMAT as column names in SELECT list

Coverage Stats

21 of 23 new or added lines in 1 file covered. (91.3%)

165 existing lines in 1 file now uncovered.

8237 of 15986 relevant lines covered (51.53%)

2526.17 hits per line