AfterShip / clickhouse-sql-parser / 25667928751

52%

master: 52%

Build Type

Pull #269

github

Committed by arifdemirel

Commit Message

Fix should treat LIMIT/OFFSET/FORMAT as columns in SELECT list when followed by `,`, AS, or another clause keyword

Mirrors PR #268: extend `isSelectItemTerminatorKeyword` to peek the next
token. A clause-starter keyword (LIMIT, OFFSET, FORMAT, SETTINGS, FROM,
…) always requires a value/expression next, so if the next token is `,`,
`AS`, or another clause-starter keyword, the current keyword is a bare
column reference, not the start of a clause.

ClickHouse server accepts `SELECT a, limit FROM t` and similar without
backtick escaping; the parser now matches.

Pull Request Pull Request #269: fix: Allow LIMIT/OFFSET/FORMAT as column names in SELECT list

Coverage Stats

36 of 56 new or added lines in 1 file covered. (64.29%)

171 existing lines in 1 file now uncovered.

8228 of 15975 relevant lines covered (51.51%)

2854.69 hits per line