0x7f454c46 / criu
54%
master: 66%

LAST BUILD BRANCH: wip/vdso-kdat
DEFAULT BRANCH: master
Repo Added
Files 2
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH tty-fix2
branch: tty-fix2
CHANGE BRANCH
x

338

push

travis-ci

0x7f454c46 
tty: prefer zalloc to malloc for inverted_path allocation

On Thu, Jun 23, 2016 at 02:12:16PM +0300, Cyrill Gorcunov wrote:
> On Thu, Jun 23, 2016 at 02:00:12PM +0300, Dmitry Safonov wrote:
> > Otherwise, we copy original name to slash and after it there may stay
> > some junk, which strcat will use for concatenation:
> > (00.024843)     26: Error (files-reg.c:1528): Can't open file dev/pts/g:��ptmx on restore: No such file or directory
> > (00.024846)     26: Error (files-reg.c:1470): Can't open file dev/pts/g:��ptmx: No such file or directory
> > (00.024849)     26: Error (tty.c:545): tty: Can't open dev/pts/g:��ptmx: No such file or directory
> >
> > Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
>
> That's big hammer, won't the below oneliner fix it?

Give attached a shot please.
----
From: Cyrill Gorcunov <gorcunov@virtuozzo.com>
Date: Thu, 23 Jun 2016 14:14:44 +0300
Subject: [PATCH] tty: Don't forget to add eol when inverting slave pts paths

Otherwise next strcat get confused

 | (00.024843)     26: Error (files-reg.c:1528): Can't open file dev/pts/g:��^?ptmx on restore: No such file or directory
 | (00.024846)     26: Error (files-reg.c:1470): Can't open file dev/pts/g:��^?ptmx: No such file or directory
 | (00.024849)     26: Error (tty.c:545): tty: Can't open dev/pts/g:��^?ptmx: No such file or directory

Reported-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@virtuozzo.com>

13774 of 25734 relevant lines covered (53.52%)

20333.92 hits per line

Relevant lines Covered
25734 RELEVANT LINES 13774 COVERED LINES
20333.92 HITS PER LINE
Source Files on tty-fix2
Detailed source file information is not available for this build.

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
338 tty-fix2 tty: prefer zalloc to malloc for inverted_path allocation On Thu, Jun 23, 2016 at 02:12:16PM +0300, Cyrill Gorcunov wrote: > On Thu, Jun 23, 2016 at 02:00:12PM +0300, Dmitry Safonov wrote: > > Otherwise, we copy original name to slash and after i... push 0x7f454c46 travis-ci pending completion  
See All Builds (352)