0x7f454c46 / criu

63%

master: 66%

LAST BUILD ON BRANCH misc

branch: misc

CHANGE BRANCH

x

Reset

• misc
• 0x-fix
• 32-vdso
• HEAD
• PAGE_SIZE-v3
• PAGE_SIZE-v4
• arm-fixes
• arm32
• arm64
• bind-nested
• bind-upwards
• cgroup-fix
• clang
• clang-fixes
• common-config
• compat-3
• compat-4
• compat-config
• compat-vz
• compat-vz-fixes
• compel-arch-5
• compel-tool-1
• compel-tool-1-vers
• coverity
• cr-exec
• criu-dev
• cyrill-32
• cyrill-32-2
• cyrill-compat-style
• dsafonov
• headers
• headers-soccr
• helper-sigchild
• ia32
• ia32/R_X86_64_32
• ia32/feature-test
• ia32/make-debug-fix
• ia32/mmap-bug-check
• ia32/robust_list
• ia32/unmap-mv
• linux-next
• make
• make-fix
• make-nmk
• makeflags
• master
• master-top-dir
• mount-fix
• mxcsr-bug
• new-vdso
• page-xfer-msg
• parasite-args-fix
• remove-CONFIG_VDSO
• rm-unmap
• signals-arm-fix
• soccr-headers
• sub-ns
• sysv-shmem
• test-make
• test-printf
• tmp
• toy-poison
• travis
• travis-gcov
• tty-fix
• tty-fix2
• tun-kdat
• v3.0-fixes
• wip/PAGE_SIZE
• wip/bind-upwards
• wip/cgroup-fix
• wip/helper-sigchild
• wip/kerndat
• wip/new-vdso
• wip/vdso-kdat
• x86-64-relocs
• x86-tls-fix
• zdtm-gnu-source
• zdtm-ifpriomap

Build # 789

Build Type

push

travis-ci

Committed by 0x7f454c46

Commit Message

compel/ksigset: fix ksigaddset() UB and flushing mask

Found by Coverity error:
> CID 172193 (#1 of 1): Bad bit shift operation (BAD_SHIFT)
> 1. large_shift: In expression 1 << sig % 64, left shifting
> by more than 31 bits has undefined behavior. The shift amount,
> sig % 64, is as much as 63.

That is:
1. yes, UB
2. while adding a signal to mask, this flushes all other signals
   from mask.

Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>

Run Details

18544 of 29349 relevant lines covered (63.18%)

55725.2 hits per line