0x7f454c46 / criu / 338
54%
master: 66%

LAST BUILD BRANCH: wip/vdso-kdat
DEFAULT BRANCH: master
Ran
Jobs 4
Files 120
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
338

push

travis-ci

0x7f454c46 
tty: prefer zalloc to malloc for inverted_path allocation

On Thu, Jun 23, 2016 at 02:12:16PM +0300, Cyrill Gorcunov wrote:
> On Thu, Jun 23, 2016 at 02:00:12PM +0300, Dmitry Safonov wrote:
> > Otherwise, we copy original name to slash and after it there may stay
> > some junk, which strcat will use for concatenation:
> > (00.024843)     26: Error (files-reg.c:1528): Can't open file dev/pts/g:��ptmx on restore: No such file or directory
> > (00.024846)     26: Error (files-reg.c:1470): Can't open file dev/pts/g:��ptmx: No such file or directory
> > (00.024849)     26: Error (tty.c:545): tty: Can't open dev/pts/g:��ptmx: No such file or directory
> >
> > Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
>
> That's big hammer, won't the below oneliner fix it?

Give attached a shot please.
----
From: Cyrill Gorcunov <gorcunov@virtuozzo.com>
Date: Thu, 23 Jun 2016 14:14:44 +0300
Subject: [PATCH] tty: Don't forget to add eol when inverting slave pts paths

Otherwise next strcat get confused

 | (00.024843)     26: Error (files-reg.c:1528): Can't open file dev/pts/g:��^?ptmx on restore: No such file or directory
 | (00.024846)     26: Error (files-reg.c:1470): Can't open file dev/pts/g:��^?ptmx: No such file or directory
 | (00.024849)     26: Error (tty.c:545): tty: Can't open dev/pts/g:��^?ptmx: No such file or directory

Reported-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@virtuozzo.com>

13774 of 25734 relevant lines covered (53.52%)

20333.92 hits per line

Jobs
ID Job ID Ran Files Coverage
1 338.1 (TR_ARCH=x86_64) 0
53.52
 Travis Job 338.1
2 338.2 (TR_ARCH=armv7hf) 0
Travis Job 338.2
3 338.3 (TR_ARCH=aarch64) 0
Travis Job 338.3
4 338.4 (TR_ARCH=ppc64le) 0
Travis Job 338.4
Source Files on build 338
Detailed source file information is not available for this build.