5633
89%
master: 89%

Ran 24 Jan 2017 07:13PM UTC

Jobs 1

Files 156

Run time 9s

Badge

Embed ▾

pending completion

Build # 5633

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

all: avoid DNS with GRPC_PROXY_EXP

In some environments DNS is not available and is performed by the
CONNECT proxy. Nothing "special" should need to be done for these
environments, but the previous support took shortcuts which knowingly
would not support such environments.

This change should fix both OkHttp and Netty. Netty's
Bootstrap.connect() resolved the name immediately whereas using
ChannelPipeline.connect() waits until the address reaches the end of the
pipeline. Netty uses NetUtil.toSocketAddressString() to get the name of
the address, which uses InetSocketAddress.getHostString() when
available.

OkHttp is still using InetSocketAddress.getHostName() which may issue
reverse DNS lookups. However, if the reverse DNS lookup fails, it should
convert the IP to a textual string like getHostString(). So as long as
the reverse DNS maps to the same machine as the IP, there should only be
performance concerns, not correctness issues. Since the DnsNameResolver
is creating unresolved addresses, the reverse DNS lookups shouldn't
occur in the common case.

Run Details

7452 of 8420 relevant lines covered (88.5%)

0.89 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5633.1	24 Jan 2017 07:13PM UTC	0	88.5	Travis Job 5633.1

Source Files on build 5633

Detailed source file information is not available for this build.

grpc / grpc-java / 5633
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5633

grpc / grpc-java / 5633 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5633

grpc / grpc-java / 5633
89%
master: 89%

README BADGES
x