2388
83%
develop: 84%

Ran 16 Jan 2017 07:21PM UTC

Jobs 1

Files 190

Run time 9s

Badge

Embed ▾

pending completion

Build # 2388

Build Type

Pull #2939

travis-ci

Committed by

web-flow

Commit Message

Include always-writable fields in data returned by API "Instance info" endpoint

When creating or updating a tree, the iOS app sends only fields known to be writable by the current user. Previously all writable fields had DB `FieldPermission` objects, but after some recent changes that is no longer true for `plot.geom`. So for newly-created treemaps users can't create trees with the iOS app because `plot.geom` is not posted to the back end.

We now have a well-defined category of "always-writable" fields, which includes `plot.geom`. So,including always-writable fields in the data returned by the API "Instance info" endpoint allows the iOS app to once again post `plot.geom` to the back end.

I abstracted the function `add_perms` from the current code (without changes), and call it twice -- once with `FieldPermission` objects from the database (as before) and once with `FieldPermission` objects temporarily constructed from `always_writable` fields.

Connects OpenTreeMap/otm-ios#337

Pull Request Pull Request #2939: Include always-writable fields in data returned by API "Instance info" endpoint

Run Details

15515 of 18628 relevant lines covered (83.29%)

0.83 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	97.92	-2.08%	treemap/management/commands/random_trees.py
1	82.26	0.17%	treemap/lib/map_feature.py
3	94.52	0.19%	api/instance.py
6	85.98	-0.93%	treemap/decorators.py
8	92.49	0.98%	treemap/tests/test_map_feature.py
10	0.0	-91.67%	treemap/exceptions.py
10	98.66	0.06%	treemap/tests/test_views.py
10	87.07	0.33%	treemap/views/user.py
13	83.44	0.0%	treemap/search_fields.py
17	89.82	0.78%	treemap/templatetags/form_extras.py
38	85.22	0.06%	treemap/models.py
39	88.39	-4.49%	treemap/instance.py
41	85.7	-0.04%	treemap/audit.py
69	26.47	-0.4%	otm1_migrator/model_processors.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	2388.1	16 Jan 2017 07:21PM UTC	190	83.29	Travis Job 2388.1

Source Files on build 2388

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

OpenTreeMap / otm-core / 2388
83%
develop: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2388

OpenTreeMap / otm-core / 2388 83% develop: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2388

OpenTreeMap / otm-core / 2388
83%
develop: 84%

README BADGES
x