2388

pending completion

Build # 2388

Build Type

Pull #2939

travis-ci

Committed by

web-flow

Commit Message

Include always-writable fields in data returned by API "Instance info" endpoint

When creating or updating a tree, the iOS app sends only fields known to be writable by the current user. Previously all writable fields had DB `FieldPermission` objects, but after some recent changes that is no longer true for `plot.geom`. So for newly-created treemaps users can't create trees with the iOS app because `plot.geom` is not posted to the back end.

We now have a well-defined category of "always-writable" fields, which includes `plot.geom`. So,including always-writable fields in the data returned by the API "Instance info" endpoint allows the iOS app to once again post `plot.geom` to the back end.

I abstracted the function `add_perms` from the current code (without changes), and call it twice -- once with `FieldPermission` objects from the database (as before) and once with `FieldPermission` objects temporarily constructed from `always_writable` fields.

Connects OpenTreeMap/otm-ios#337

Pull Request Pull Request #2939: Include always-writable fields in data returned by API "Instance info" endpoint

Run Details

15515 of 18628 relevant lines covered (83.29%)

0.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

26.47

opentreemap/otm1_migrator/model_processors.py

Build SHA Not Found

The commit SHA "60f83540a725fe369e0e71af800a12fafb66d599" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

OpenTreeMap / otm-core / 2388

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous