Instagram / IGListKit / 689

100%

Build Type

push

travis-ci

Committed by Facebook Github Bot

Commit Message

Invalidate layout when using reloadData

Summary:
Always invalidate the `collectionViewLayout` when calling `reloadData`. Turns out there are inconsistencies when layout attributes are queries/stored using `UICollectionViewFlowLayout` and `estimatedItemSize`.

Reproduced in unit test, fixed the test.

Closes #305

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/319

Differential Revision: D4329318

Pulled By: rnystrom

fbshipit-source-id: 91851f6ab

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

2727 of 2784 relevant lines covered (97.95%)

464.9 hits per line