222
0%

Ran 09 Nov 2016 02:01PM UTC

Jobs 5

Files 28

Run time 2min

Badge

Embed ▾

pending completion

Build # 222

Build Type

Pull #92

travis-ci

Committed by

web-flow

Commit Message

Make confluence_version a First Class Fact

This stems from the fact that the confluence module unconditionally manages the
directory /etc/puppetlabs/facter/facts.d directory in the sense that if the code
gets evaluated first you run into the age old race condition of clashing with other
classes who wish to manage it.  This removes said management, moves the fact
to a ruby/puppet native which yields slightly prettier and less code.

The change to `confluence::service` was required to get CI to pass.  I'd properly
refactor this but it'd probably destroy users how already reference in hiera
`confluence::service::service_file_location` etc.

Pull Request Pull Request #92: Make confluence_version a First Class Fact

Run Details

393 of 676 relevant lines covered (58.14%)

3.65 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
17	28.57	-1.31%	spec/fixtures/modules/archive/lib/puppet/provider/archive/ruby.rb
23	65.33	-0.18%	spec/fixtures/modules/archive/lib/puppet/type/archive.rb

Jobs

ID	Job ID	Ran	Files	Coverage
3	222.3 (2.1.9, PUPPET_VERSION="~> 3.0" STRICT_VARIABLES="yes" CHECK=test)	09 Nov 2016 02:01PM UTC	28	58.25	Travis Job 222.3
4	222.4 (2.1.9, PUPPET_VERSION="~> 4.0" CHECK=test)	09 Nov 2016 02:01PM UTC	28	58.25	Travis Job 222.4
5	222.5 (2.2.5, PUPPET_VERSION="~> 4.0" CHECK=test)	09 Nov 2016 02:01PM UTC	28	58.25	Travis Job 222.5
8	222.8 (2.3.1, PUPPET_VERSION="~> 4.0" CHECK=test)	09 Nov 2016 02:02PM UTC	28	58.25	Travis Job 222.8
9	222.9 (2.4.0-preview1, PUPPET_VERSION="~> 4.0" CHECK=test)	09 Nov 2016 02:03PM UTC	28	58.14	Travis Job 222.9

Source Files on build 222

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

voxpupuli / puppet-confluence / 222
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 222

voxpupuli / puppet-confluence / 222 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 222

voxpupuli / puppet-confluence / 222
0%

README BADGES
x