voxpupuli / puppet-confluence / 222

pending completion

Build # 222

Build Type

Pull #92

travis-ci

Committed by

web-flow

Commit Message

Make confluence_version a First Class Fact

This stems from the fact that the confluence module unconditionally manages the
directory /etc/puppetlabs/facter/facts.d directory in the sense that if the code
gets evaluated first you run into the age old race condition of clashing with other
classes who wish to manage it.  This removes said management, moves the fact
to a ruby/puppet native which yields slightly prettier and less code.

The change to `confluence::service` was required to get CI to pass.  I'd properly
refactor this but it'd probably destroy users how already reference in hiera
`confluence::service::service_file_location` etc.

Pull Request Pull Request #92: Make confluence_version a First Class Fact

Run Details

393 of 676 relevant lines covered (58.14%)

3.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.33

/spec/fixtures/modules/archive/lib/puppet/type/archive.rb

Build SHA Not Found

The commit SHA "2d795b7e22dbfdc0d68d755c9d34bb195d2ae42a" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

voxpupuli / puppet-confluence / 222

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous