• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

coreui / coreui-pro / 44310689310
97%
main: 94%

Build:
Build:
LAST BUILD BRANCH: v6-dev
DEFAULT BRANCH: main
Ran 18 Nov 2026 01:11PM UTC
Jobs 1
Files 96
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Nov 2026 01:08PM UTC coverage: 96.793% (+0.005%) from 96.788%
44310689310

push

github

web-flow
fix(Dialog,Drawer,Modal,Offcanvas): give the focus back and hold announcements when dialogs open and close (#1845)

* test(Modal): pin the announcement hold of dispose() on an open dialog

dispose() on an open dialog runs _closeAndCleanup(), which holds the page
announcements for half a second, but no spec checked it: replacing the call
with close() and the scroll lock removal passed the dispose specs. The new
spec sends a message after dispose() and expects it at 500 ms, not before.
The accessibility page now says dispose() closes the dialog the same way,
as the React and Vue pages say for an unmount.

* test(Modal): pin that dispose() of a closed dialog holds nothing

dispose() runs _closeAndCleanup(), and with it the announcement hold, only
for an open dialog. Dropping that guard kept every spec green while a page
that disposes its closed dialogs on a route change would wait half a second
for its next message. The new spec disposes a closed dialog and expects a
message one task later.

* fix(announce): hold every waiting message after a dialog closes

holdAnnouncements() held only the host it picked when it was called, the
page or the modal dialog open at that moment. When a page closes one modal
dialog and opens another a moment later, as two React or Vue dialogs toggled
by `show` do, or hide() followed by show() on two `.modal-instant` Modals,
the hold went to the page. The message sent from that click reached the new
dialog's region about 200 ms later, while VoiceOver was reading the dialog
that took focus, and Chrome dropped it in 5 of 5 and 5 of 6 runs.

The hold now applies to the whole queue, so the message waits until half a
second after the close wherever it goes, and VoiceOver in Chrome read it in
6 of 6 runs in both cases. The per-host map of holds goes away with it.

* fix(Dialog,Drawer,Modal,Offcanvas): give the focus back where the chain of dialogs started

A dialog opened from a button inside another dialog remembered that button
as ... (continued)

8472 of 8976 branches covered (94.39%)

Branch coverage included in aggregate %.

36 of 36 new or added lines in 6 files covered. (100.0%)

14223 of 14471 relevant lines covered (98.29%)

2330.41 hits per line

Jobs
ID Job ID Ran Files Coverage
1 44310689310.1 18 Nov 2026 01:11PM UTC 96
96.79
GitHub Action Run
Source Files on build 44310689310
  • Tree
  • List 96
  • Changed 8
  • Source Changed 8
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #44310689310
  • 5c39b7d2 on github
  • Prev Build on v6-dev (#44302670932)
  • Next Build on v6-dev (#44314847656)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc