• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43611463250
96%

Build:
DEFAULT BRANCH: main
Ran 14 Nov 2026 03:53PM UTC
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Nov 2026 03:40PM UTC coverage: 96.333% (+0.008%) from 96.325%
43611463250

push

github

web-flow
Add password and Add folder: refuse hidden names and places behind links (#2163)

Three things in the same two paths:

- A name with a part that starts with a dot was accepted. The tree hides
  such names, as `pass ls` does, so the entry or folder was made but never
  listed. PasswordDialog::resolveNewEntry() keeps OK off with a reason,
  and MainWindow::addFolder() warns "Hidden folder".
- A place behind a symbolic link or junction was accepted: the boundary
  check resolves links and passes anything that ends in the store, and
  Util::mkpathForStore() follows them. Add folder made the folder in the
  link's target, and Add password created the entry's folder there before
  Insert() refused the save. Both now check Util::isUnderLink(), as Users,
  Re-encrypt and Delete already do (refuseLinkedFolder()).
- PathValidator::storeRelativePath() climbed to the nearest existing
  folder with QDir::cdUp(), which refuses to move into a folder that does
  not exist either. A new entry two missing folders deep ("a/b/entry")
  therefore counted as outside the store. It now climbs by name.

Tests: newEntryNameRefusesHiddenAndLinkedPlaces (tst_passworddialog),
addFolderRefusesHiddenAndLinkedPlaces (tst_mainwindow) and two more cases
in isPathInStoreHappyPath (tst_util). Each of the five checks was removed
in turn; the matching test then fails.

The four new strings get their translations in the translation-review
pull request, which runs lupdate.

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

20 of 20 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

8380 of 8699 relevant lines covered (96.33%)

470.89 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
93.62
0.28% src/pathvalidator.cpp
Jobs
ID Job ID Ran Files Coverage
1 43611463250.1 14 Nov 2026 03:53PM UTC 87
96.33
GitHub Action Run
Source Files on build 43611463250
  • Tree
  • List 87
  • Changed 3
  • Source Changed 3
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43611463250
  • f531490e on github
  • Prev Build on main (#43608906972)
  • Next Build on main (#43617539964)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc