• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 43511974237
96%

Build:
DEFAULT BRANCH: main
Ran 13 Nov 2026 09:45PM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Nov 2026 09:34PM UTC coverage: 92.717% (-0.001%) from 92.718%
43511974237

push

github

web-flow
Users dialog: keep the recipient selection when importing a key (#2145)

* Users dialog: keep the recipient selection when importing a key

"Import key..." in the Users dialog reloaded the key list with loadGpgKeys(),
which rebuilds it from the keyring and drops every tick - the .gpg-id
recipients and the user's own ticks alike. If the user then ticked only the
imported key and pressed OK, the saved .gpg-id named that key alone and the
other recipients (including the user's own key) lost access.

on_importKeyButton_clicked() now remembers the selected recipients before the
reload and re-applies them by exact key ID afterwards, re-adding any that are
no longer in the keyring as a "key not found" row. Importing only adds the new
key's row; it still does not tick it.

The existing import test is updated: it ticks a recipient before importing and
checks the tick survives (it failed before the change).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Users dialog: resolve short-id/email recipients when re-applying on import

Per review: a .gpg-id recipient named by a short key ID or email that gpg
could not resolve is stored verbatim as a "key not found" row; importing its
key makes the refreshed row carry the fingerprint, which an exact match
misses. Match saved identifiers by key ID first, then hand any that do not
match to selectRecipients(), which resolves them against the refreshed
keyring and ticks the now-present row (or re-adds a not-found row).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

---------

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

11 of 12 new or added lines in 1 file covered. (91.67%)

10477 of 11300 relevant lines covered (92.72%)

406.7 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
98.31
-0.35% src/usersdialog.cpp
Jobs
ID Job ID Ran Files Coverage
1 43511974237.1 13 Nov 2026 09:45PM UTC 127
92.72
GitHub Action Run
Source Files on build 43511974237
  • Tree
  • List 127
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43511974237
  • 7c478df2 on github
  • Prev Build on main (#43507154971)
  • Next Build on main (#43515183873)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc